Reviewed-by: Liming Gao <[email protected]> -----Original Message----- From: Ard Biesheuvel [mailto:[email protected]] Sent: Thursday, December 03, 2015 1:03 AM To: [email protected]; [email protected]; Gao, Liming; Zhang, Chao B; Carsey, Jaben; Qiu, Shumin; Fan, Jeff; Tian, Feng Cc: Ard Biesheuvel Subject: [PATCH 2/5] MdeModulePkg: remove unreachable code
Some compilers (like RVCT) are finicky about unreachable code, so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel <[email protected]> --- MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c | 3 --- MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c | 1 - MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 1 - 3 files changed, 5 deletions(-) diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c b/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c index bbbbdaa8c124..732dd2f3de7a 100644 --- a/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c +++ b/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c @@ -229,7 +229,6 @@ ReadString ( return EFI_DEVICE_ERROR; } - break; case CHAR_BACKSPACE: if (StringPtr[0] != CHAR_NULL && CurrentCursor != 0) { @@ -881,7 +880,6 @@ TheKey2: } goto EnterCarriageReturn; - break; case SCAN_UP: case SCAN_DOWN: @@ -982,7 +980,6 @@ EnterCarriageReturn: } return EFI_SUCCESS; - break; case CHAR_BACKSPACE: if (ManualInput) { diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c b/MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c index c074f4b4a39a..bb2faf3244d4 100644 --- a/MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c +++ b/MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c @@ -568,7 +568,6 @@ PrintFormattedNumber ( default: return EFI_UNSUPPORTED; - break; } UnicodeSPrint (FormattedNumber, BufferSize, Format, Value); diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c index 688a1d66cb40..9a18dec5c03b 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c @@ -3170,7 +3170,6 @@ EvaluateExpression ( // Status = EFI_UNSUPPORTED; goto Done; - break; } } else { // -- 1.9.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
