Jordan, Responses below.
I have posted a Quark_V2 branch on github that is synched with the EDK II trunk as of today. https://github.com/mdkinney/edk2/tree/Quark_V2 Thanks, Mike > -----Original Message----- > From: Justen, Jordan L > Sent: Thursday, December 10, 2015 10:02 PM > To: Kinney, Michael D <[email protected]>; edk2- > [email protected] ([email protected]) <edk2- > [email protected]> > Cc: Kinney, Michael D <[email protected]> > Subject: Re: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg > packages > > On 2015-11-25 00:18:55, Kinney, Michael D wrote: > > Add 2 packages required for Intel Galileo and Intel Galileo > Gen 2 > > development boards with the Quark Soc X1000. > > > > Patch email would be a bit large, so here is link to a github > branch of edk2 with > > the new package contents for review. > > > > https://github.com/mdkinney/edk2/tree/Quark > > Can you rebase your branches before posting them? > > $ git fetch origin > $ git rebase origin/master > > This can get a little tricky when there are conflicts in the > changes > between your branch and the main upstream branch, but your Quark > branch had no conflicts. (If there are conflicts, you are going > to > eventually have to deal with them.) > I just pushed Quark_V2 to github that is rebased to trunk as of a few minutes ago and addresses all conflicts and passes your PatchCheck.py script. > Regarding posting code, does giving a link to a branch cover the > Contributed-under/Signed-off-by process? I think it might be > best to > post the patches and link to the branch. (Although, obviously > the > patches themselves would be tough to review directly.) The patch files are 1.7 MB and 1.5 MB. Very big to send to edk2-devel. Any suggestions? > > Neither QuarkSocPkg, nor QuarkPlatformPkg have a License.txt. > Generally we'd want to just copy it from MdePkg. I have fixed this in the Quark_V2 branch on github. > > I see QuarkSocPkg/QuarkNorthCluster/Binary/QuarkMicrocode... > Well, at > least, unlike Vlv2TbltDevicePkg/Stitch, the size is reasonable. > :) > > I don't think it should be included in the same package as > otherwise > BSD licensed code. I think you should put it into a separate > package, > or perhaps repo, and you should mention the different license, > since > it is not covered by MdePkg/Contributions.txt. There has been > some > talk of removing FatBinPkg from the tree due to the license, so > where > does that leave this module? I prefer to keep this in the same package because it is associated directly with the QuarkSoc. What about this license do you think is not compatible with the contributor's agreement? We prefer BSD, but other licenses are allowed. > > Regarding > QuarkSocPkg/QuarkNorthCluster/Binary/QuarkMicrocode/IntelProprie > taryLicense.txt, > can it be renamed to License.txt? MdePkg/Contributions.txt only > mentions License.txt. > > -Jordan > > > > > The QuarkPlatformPkg has 2 DSC files > > ================================ > > Quark.dsc Supports full > configuration > > QuarkMin.dsc Min config for initial power- > on/debug > > > > Quark.dsc supports the following defines > > ==================================== > > GALILEO > > LOGGING > > SOURCE_DEBUG_ENABLE > > SECURE_BOOT_ENABLE > > PERFORMANCE_ENABLE > > > > Example build command for Galileo > > > > build -a IA32 -t VS2013x86 -p > QuarkPlatformPkg/Quark.dsc -D GALILEO=GEN1 > > > > Example build command for Galileo GEN2 > > > > build -a IA32 -t VS2013x86 -p > QuarkPlatformPkg/Quark.dsc > > > > The default serial console for Galileo is 460800n81 > > The default serial console for Galileo Gen 2 is 921600n81 > > > > There is more work to add features and clean up some code > style > > issues, but this initial set of content boots to the UEFI > shell and the > > operating systems supported by Galileo. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Michael Kinney > <[email protected]<mailto:[email protected]>> > > > > > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
