Jordan,
Reponses included below.
1) edk2: Maintainers.txt patch email sent.
2) Thank you very much for ack and detailed review/feedback in Quark*Pkgs
3) I have fixed all the items for the edk2-non-osi repository and pushed them
to:
https://github.com/mdkinney/edk2-non-osi.git
Can you create the new edk2-non-osi repository on tianocore and import this
content?
Thanks,
Mike
> -----Original Message-----
> From: Justen, Jordan L
> Sent: Monday, December 14, 2015 11:47 PM
> To: Kinney, Michael D <[email protected]>; edk2-
> [email protected] ([email protected]) <edk2-
> [email protected]>
> Subject: RE: [edk2] [PATCH] Add QuarkSocPkg and QuarkPlatformPkg
> packages
>
> On 2015-12-13 14:48:54, Kinney, Michael D wrote:
> > Jordan,
> >
> > I have updated to Quark_V3 that uses this concept along with a
> > proposed edk2-non-osi repository with a new QuarkSocBinPkg. It
> uses
> > PACKAGES_PATH to support the multiple repositories to do a
> build.
> > The content is posted for review on GitHub.
> >
> > The QuarkSocPkg and QuarkPlatformPkg are in branch Quark_V3 on
> GitHub at:
> >
> > https://github.com/mdkinney/edk2.git
> >
> > The edk2-non-iso repository with the QuarkSocBinPkg is on
> GitHub at:
> >
> > https://github.com/mdkinney/edk2-non-osi.git
> >
> > Here are the instructions I use to clone the content and set
> > environment variables to perform platform builds.
> >
> >
> ================================================================
> ======
> > git clone https://github.com/mdkinney/edk2.git --branch
> Quark_V3
>
> I notice that this file doesn't have the standard copyright
> header:
>
> QuarkPlatformPkg/Library/PlatformSecLib/PlatformSecLibModStrs.un
> i
>
> I found this with:
>
> $ git grep -L 'http://opensource.org/licenses/bsd-license.php'
> Quark*
>
Thanks. I have fixed this.
> Also, QuarkPlatformPkg/License.txt and QuarkSocPkg/License.txt
> are
> using unix line endings. How about copying MdePkg/License.txt
> directly?
>
> I found this with:
>
> $ md5sum */License.txt
>
I found these 2 license files yesterday with wrong line endings. I have fixed
them.
I also found a C source file with a Unicode '-' character in it, and I fixed
that too.
> With these fixed:
>
> Acked-by: Jordan Justen <[email protected]>
>
> So, I guess these probably two changes are ready to commit,
> right?
Thank you very much for the detailed reviews and feedback.
Yes. I am ready to commit these two packages.
>
> * QuarkPlatformPkg: Add new package for Galileo boards
> * QuarkSocPkg: Add new package for Quark SoC X1000
>
> Can you send out a patch for the Maintainers.txt?
Yes. I have sent patch review email.
>
> > git clone https://github.com/tianocore/edk2-FatPkg.git FatPkg
> > git clone https://github.com/mdkinney/edk2-non-osi.git
>
> I also reviewed the updated edk2-non-osi tree with
> 5573e513dfb88f96c8ae08471e369c335a540a37 "QuarkSocBinPkg:
> Reformat
> IntelProprietaryLicense.txt". I think you should just squash
> that into
> the previous commit.
Done
>
> Also, in:
>
> In QuarkSocBinPkg/License.txt
>
> You have this text:
>
> > Additional terms:
> > -----------------
> >
> QuarkSocBinPkg\QuarkNorthCluster\Binary\QuarkMicrocode\IntelProp
> rietaryLicense.txt
>
> This sounds similar to the FAT driver, where all of the content
> has
> BSD + and additional term. But, in this case, the license only
> applies
> to 1 file. How about something like what we have in
> OvmfPkg/License.txt? For example:
>
> > Some files are subject to a license documented in the
> > IntelProprietaryLicense.txt file. These files are in the same
> > directory as IntelProprietaryLicense.txt, and they do not have
> a
> > license specified within the file.
Done
>
> -Jordan
>
> > git clone https://github.com/tianocore/edk2-BaseTools-
> win32.git
> >
> > set WORKSPACE=%CD%
> > set PACKAGES_PATH=%WORKSPACE%\edk2;%WORKSPACE%\edk2-non-osi
> > set EDK_TOOLS_BIN=%WORKSPACE%\edk2-BaseTools-win32
> >
> > cd edk2
> >
> > edkSetup.bat
> >
> > build -a IA32 -t VS2015x86 -p QuarkPlatformPkg/Quark.dsc
> > build -a IA32 -t VS2015x86 -p QuarkPlatformPkg/QuarkMin.dsc
> >
> ================================================================
> =
> >
> > commit 613f0f5ff082d85e02403eddefdc1d54138663c5
> > Author: Michael Kinney <[email protected]>
> > Date: Tue Nov 24 23:43:40 2015 -0800
> >
> > QuarkPlatformPkg: Add new package for Galileo boards
> >
> > Changes for V3
> > 1) Set PcdResetOnMemoryTypeInformationChange FALSE in
> QuarkMin.dsc
> > This is required because QuarkMin.dsc uses the emulated
> variable
> > driver that does not preserve any non-volatile UEFI
> variables
> > across reset. If the condition is met where the memory
> type
> > information variable needs to be updated, then the system
> will reset
> > every time the UEFI Shell is run. By setting this PCD to
> FALSE,
> > then reset action is disabled.
> > 2) Move one binary file to QuarkSocBinPkg
> > 3) Change RMU.bin FILE statements to INF statement in DSC
> FD region
> > to be compatible with PACKAGES_PATH search for
> QuarkSocBinPkg
> >
> > Changes for V2
> > 1) Use new generic PCI serial driver PciSioSerialDxe in
> MdeModulePkg
> > 2) Configure PcdPciSerialParameters for PCI serial driver
> for Quark
> > 3) Use new MtrrLib API to reduce time to set MTRRs for all
> DRAM
> > 4) Convert all UNI files to utf-8
> > 5) Replace tabs with spaces and remove trailing spaces
> > 6) Add License.txt
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Michael Kinney <[email protected]>
> >
> > commit a7c963fd7acf91fc3d33aeda6bd0064a006d26c4
> > Author: Michael Kinney <[email protected]>
> > Date: Tue Nov 24 23:42:53 2015 -0800
> >
> > QuarkSocPkg: Add new package for Quark SoC X1000
> >
> > Changes for V2
> > 1) Sync with new APIs in SmmCpuFeaturesLib class
> > 2) Use new generic PCI serial driver PciSioSerialDxe in
> MdeModulePkg
> > 3) Remove PCI serial driver from QuarkSocPkg
> > 4) Apply optimizations to MtrrLib from MtrrLib in
> UefiCpuPkg
> > 5) Convert all UNI files to utf-8
> > 6) Replace tabs with spaces and remove trailing spaces
> > 7) Add License.txt
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Michael Kinney <[email protected]>
> >
> >
> > commit 106b4383d6d9fc0b09fd8cd8d1bbfcf6fe9c945d
> > Author: Michael Kinney <[email protected]>
> > Date: Sun Dec 13 11:16:53 2015 -0800
> >
> > QuarkSocBinPkg: Add tiancore required text files
> >
> > Add Maintainers.txt that lists maintainers for
> QuarkSocBinPkg
> > Add Contributions.txt to QuarkSocBinPkg
> > Add License.txt to QuarkSocBinPkg
> > Fix line endings
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Michael Kinney <[email protected]>
> >
> > commit 10ccd635c4c3d20da713aef4122a14d510016b8b
> > Author: Michael Kinney <[email protected]>
> > Date: Sat Dec 12 18:37:15 2015 -0800
> >
> > QuarkSocBinPkg: Add RMU binary module for QuarkSocPkg
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Michael Kinney <[email protected]>
> >
> > Best regards,
> >
> > Mike
> >
> >
> > > -----Original Message-----
> > > From: Justen, Jordan L
> > > Sent: Saturday, December 12, 2015 9:31 PM
> > > To: Kinney, Michael D <[email protected]>; edk2-
> > > [email protected] ([email protected]) <edk2-
> > > [email protected]>
> > > Subject: RE: [edk2] [PATCH] Add QuarkSocPkg and
> QuarkPlatformPkg
> > > packages
> > >
> > > On 2015-12-10 22:24:39, Kinney, Michael D wrote:
> > > > > -----Original Message-----
> > > > > From: Justen, Jordan L
> > > > > Sent: Thursday, December 10, 2015 10:02 PM
> > > > >
> > > > > I don't think it should be included in the same package
> as
> > > > > otherwise BSD licensed code. I think you should put it
> into
> > > a
> > > > > separate package, or perhaps repo, and you should
> mention
> > > the
> > > > > different license, since it is not covered by
> > > > > MdePkg/Contributions.txt. There has been some talk of
> > > removing
> > > > > FatBinPkg from the tree due to the license, so where
> does
> > > that
> > > > > leave this module?
> > > >
> > > > I prefer to keep this in the same package because it is
> > > associated
> > > > directly with the QuarkSoc. What about this license do you
> > > think is
> > > > not compatible with the contributor's agreement? We prefer
> > > BSD, but
> > > > other licenses are allowed.
> > > >
> > >
> > > There is still a case to be made to separate all the content
> > > which is
> > > under an OSI (https://opensource.org/) approved license from
> > > content
> > > that is not.
> > >
> > > What if we make a https://github.com/tianocore/edk2-non-osi
> > > repository
> > > to add this and similar content under?
> > >
> > > Now that we support PACKAGES_PATH, this should work
> reasonably
> > > well.
> > > Then certain platforms can depend on the edk2-non-osi repo.
> > >
> > > -Jordan
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
