Jeff,
With this change X64 OVMF boots. Thanks for the quick fix.
Please add a comment above declaration of structure MP_CPU_EXCHANGE_INFO that
the structure is required to be packed because fixed field offsets into this
structure are used in assembly code in this module.
With that comment added:
Reviewed-by: Michael Kinney <michael.d.kin...@intel.com>
Mike
> -----Original Message-----
> From: Fan, Jeff
> Sent: Thursday, December 17, 2015 6:16 AM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D
> <michael.d.kin...@intel.com>; Justen, Jordan L
> <jordan.l.jus...@intel.com>
> Subject: [Patch] UefiCpuPkg/CpuMpPei: Fix pack(1) issue on x64
> arch
>
> Packing alignment for MP_CPU_EXCHANGE_INFO should be 1. This
> should be typo when
> check-in CpuMpPei driver. IA32 arch MP_CPU_EXCHANGE_INFO is
> luckly pack(1). It
> leads CpuMpPei x64 version hung.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Reported-by: Michael Kinney <michael.d.kin...@intel.com>
> Cc: Feng Tian <feng.t...@intel.com>
> Cc: Michael Kinney <michael.d.kin...@intel.com>
> Cc: Jordan Justen <jordan.l.jus...@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeff Fan <jeff....@intel.com>
> ---
> UefiCpuPkg/CpuMpPei/CpuMpPei.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.h
> b/UefiCpuPkg/CpuMpPei/CpuMpPei.h
> index f2286b9..2460f4a 100644
> --- a/UefiCpuPkg/CpuMpPei/CpuMpPei.h
> +++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.h
> @@ -72,7 +72,7 @@ typedef struct {
>
> typedef struct _PEI_CPU_MP_DATA PEI_CPU_MP_DATA;
>
> -#pragma pack()
> +#pragma pack(1)
>
> typedef union {
> struct {
> --
> 1.9.5.msysgit.0
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
