Mike, Thanks your testing. I will add your comment when check-in the code.
Jeff -----Original Message----- From: Kinney, Michael D Sent: Friday, December 18, 2015 10:20 AM To: Fan, Jeff; [email protected]; Kinney, Michael D Cc: Tian, Feng; Justen, Jordan L Subject: RE: [Patch] UefiCpuPkg/CpuMpPei: Fix pack(1) issue on x64 arch Jeff, With this change X64 OVMF boots. Thanks for the quick fix. Please add a comment above declaration of structure MP_CPU_EXCHANGE_INFO that the structure is required to be packed because fixed field offsets into this structure are used in assembly code in this module. With that comment added: Reviewed-by: Michael Kinney <[email protected]> Mike > -----Original Message----- > From: Fan, Jeff > Sent: Thursday, December 17, 2015 6:16 AM > To: [email protected] > Cc: Tian, Feng <[email protected]>; Kinney, Michael D > <[email protected]>; Justen, Jordan L > <[email protected]> > Subject: [Patch] UefiCpuPkg/CpuMpPei: Fix pack(1) issue on x64 arch > > Packing alignment for MP_CPU_EXCHANGE_INFO should be 1. This should be > typo when check-in CpuMpPei driver. IA32 arch MP_CPU_EXCHANGE_INFO is > luckly pack(1). It leads CpuMpPei x64 version hung. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Reported-by: Michael Kinney <[email protected]> > Cc: Feng Tian <[email protected]> > Cc: Michael Kinney <[email protected]> > Cc: Jordan Justen <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jeff Fan <[email protected]> > --- > UefiCpuPkg/CpuMpPei/CpuMpPei.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.h > b/UefiCpuPkg/CpuMpPei/CpuMpPei.h index f2286b9..2460f4a 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuMpPei.h > +++ b/UefiCpuPkg/CpuMpPei/CpuMpPei.h > @@ -72,7 +72,7 @@ typedef struct { > > typedef struct _PEI_CPU_MP_DATA PEI_CPU_MP_DATA; > > -#pragma pack() > +#pragma pack(1) > > typedef union { > struct { > -- > 1.9.5.msysgit.0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
