Yes, below set but not used local variable will cause GCC build error. I agree this change.
Reviewed-by: Jiaxin Wu <[email protected]<mailto:[email protected]>> Thanks. Jiaxin From: Shivamurthy Shastri [mailto:[email protected]] Sent: Thursday, February 18, 2016 7:18 PM To: Leahy, Leroy P <[email protected]>; [email protected]; Wu, Jiaxin <[email protected]> Cc: [email protected] Subject: Fwd: [edk2] [PATCH] Ax88772b: Fixing compilation error variable set but not used Hi All, Please let me know your opinion about this patch. -- Thanks and Regards, Shivamurthy Shastri, M: +919742508553, IRC: shiva_murthy, Linaro.org |Open Source Software for ARM SOCs ---------- Forwarded message ---------- From: Shivamurthy Shastri <[email protected]<mailto:[email protected]>> Date: 10 February 2016 at 19:37 Subject: [edk2] [PATCH] Ax88772b: Fixing compilation error variable set but not used To: [email protected]<mailto:[email protected]> Cc: [email protected]<mailto:[email protected]>, Shivamurthy Shastri <[email protected]<mailto:[email protected]>> error: pNicDevice variable set but not used Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Shivamurthy Shastri <[email protected]<mailto:[email protected]>> --- OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c index 9eeb61f..c061a6b 100644 --- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c +++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c @@ -700,10 +700,8 @@ SN_ReceiveFilters ( EFI_SIMPLE_NETWORK_MODE * pMode; EFI_STATUS Status = EFI_SUCCESS; EFI_TPL TplPrevious; - NIC_DEVICE * pNicDevice; TplPrevious = gBS->RaiseTPL(TPL_CALLBACK); - pNicDevice = DEV_FROM_SIMPLE_NETWORK ( pSimpleNetwork ); pMode = pSimpleNetwork->Mode; if (pSimpleNetwork == NULL) { -- 1.9.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
