I cannot see the patch. Can you send it out in a separate mail? Regards, Ray
From: edk2-devel [mailto:[email protected]] On Behalf Of Shivamurthy Shastri Sent: Wednesday, March 30, 2016 10:21 AM To: Ni, Ruiyu <[email protected]> Cc: Fathi Boudra <[email protected]>; [email protected]; Laszlo Ersek <[email protected]> Subject: Re: [edk2] [PATCH] Ax88772b: Fixing compilation error variable set but not used On 17 March 2016 at 14:19, Shivamurthy Shastri < [email protected]<mailto:[email protected]>> wrote: > > On 19 February 2016 at 18:06, Shivamurthy Shastri < > [email protected]<mailto:[email protected]>> wrote: > >> >> On 19 February 2016 at 17:45, Laszlo Ersek >> <[email protected]<mailto:[email protected]>> wrote: >> >>> On 02/19/16 13:04, Shivamurthy Shastri wrote: >>> > On 19 February 2016 at 16:30, Laszlo Ersek >>> > <[email protected]<mailto:[email protected]>> wrote: >>> > >>> >> On 02/10/16 15:07, Shivamurthy Shastri wrote: >>> >>> error: pNicDevice variable set but not used >>> >>> >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> >>> Signed-off-by: Shivamurthy Shastri >>> >>> <[email protected]<mailto:[email protected]>> >>> >>> --- >>> >>> OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c | 2 -- >>> >>> 1 file changed, 2 deletions(-) >>> >>> >>> >>> diff --git >>> a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c >>> >> b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c >>> >>> index 9eeb61f..c061a6b 100644 >>> >>> --- a/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c >>> >>> +++ b/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c >>> >>> @@ -700,10 +700,8 @@ SN_ReceiveFilters ( >>> >>> EFI_SIMPLE_NETWORK_MODE * pMode; >>> >>> EFI_STATUS Status = EFI_SUCCESS; >>> >>> EFI_TPL TplPrevious; >>> >>> - NIC_DEVICE * pNicDevice; >>> >>> >>> >>> TplPrevious = gBS->RaiseTPL(TPL_CALLBACK); >>> >>> - pNicDevice = DEV_FROM_SIMPLE_NETWORK ( pSimpleNetwork ); >>> >>> pMode = pSimpleNetwork->Mode; >>> >>> >>> >>> if (pSimpleNetwork == NULL) { >>> >>> >>> >> >>> >> As I said in the other (similar) thread, the subject should identify >>> the >>> >> top level package. It should go: >>> >> >>> >> OptionRomPkg: Ax88772b: ... >>> >> >>> >> Thanks >>> >> Laszlo >>> >> >>> > >>> > I will send new patch for that. >>> >>> If there are no other changes required for your patch(es), then the >>> maintainer who commits the patch(es) can fix up the subject(s) at commit >>> time. No need to resend just for the subject change. >>> >>> Thanks >>> Laszlo >>> >>> >> OK, Thanks for review. >> I will add Ruiyu Ni >> >> > Hi Ruiyu Ni, > > Please look into the patch. > > Thanks, > Shiva > > Hi Ruiyu Ni, Please review the patch. This patch fixes compilation error "set but unused variable". This occurs with GCC. Thanks, Shiva _______________________________________________ edk2-devel mailing list [email protected]<mailto:[email protected]> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
