On 26 February 2016 at 16:21, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > On 26 February 2016 at 17:16, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> On trying to review some really useful improvements to the PL061 driver, >> I found myself failing due to the unreadability of the existing code. >> This series reworks the existing driver in preparation for the >> improvements. >> > > For the series: > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > And me:
Reviewed-by: Ryan Harkin <ryan.har...@linaro.org> >> Changes since RFC: >> - Rework the initialization code based on feedback from Ard. >> - Bugfix reported by Ard and tested by Haojian. >> - Moved the Linaro Copyright introduction to first patch that >> actually touches code. >> - Dropped a spurious blank line deletion. >> >> Leif Lindholm (4): >> ArmPlatformPkg: PL061 - reformat copyright statement. >> ArmPlatformPkg: PL061 - only initialize on protocol load >> ArmPlatformPkg: PL061 - drop pointless initialize function >> ArmPlatformPkg: PL061 - rewrite the hardware interaction >> >> ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 143 >> ++++++++++++------------ >> ArmPlatformPkg/Include/Drivers/PL061Gpio.h | 5 +- >> 2 files changed, 72 insertions(+), 76 deletions(-) >> >> -- >> 2.1.4 >> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel