Hi Haojian,

On Fri, Feb 26, 2016 at 05:27:47PM +0800, Haojian Zhuang wrote:
> * Wait OCR busy bit free according to eMMC spec.
> * Define ECSD structure.
> * Add interface to set IO bus width and speed.
> * Support to access multiple blocks.

This is a substantial contribution, and on inspection it looks fine.
However, it does change bits of MmcDxe substantially - so I would
really like to see some Tested-by:s for existing platforms.

Ryan?
Anyone else?

Also, to make it easier to test the series - could you push it to a
public git repository (presumably git.linaro.org)?

Regards,

Leif

> Haojian Zhuang (9):
>   MmcDxe: wait OCR busy bit free
>   MmcDxe: move ECSD into CardInfo structure
>   MmcDxe: add SPEC_VERS field in CSD structure
>   MmcDxe: add interface to change io width and speed
>   MmcDxe: declare ECSD structure
>   MmcDxe: set io bus width before reading EXTCSD
>   MmcDxe: Fix uninitialized mediaid for SD
>   MmcDxe: set iospeed and bus width in SD stack
>   MmcDxe: expand to support multiple blocks
> 
>  EmbeddedPkg/Include/Protocol/MmcHost.h           |  27 ++
>  EmbeddedPkg/Universal/MmcDxe/Mmc.h               | 176 +++++++++++-
>  EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c        | 175 ++++++++----
>  EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 342 
> +++++++++++++++++++++--
>  4 files changed, 635 insertions(+), 85 deletions(-)
> 
> -- 
> 1.9.1
> 
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to