On 27 February 2016 at 08:48, Haojian Zhuang <[email protected]> wrote:
> On 2016/2/27 4:38, Leif Lindholm wrote:
>>
>> Hi Haojian,
>>
>> On Fri, Feb 26, 2016 at 05:27:47PM +0800, Haojian Zhuang wrote:
>>>
>>> * Wait OCR busy bit free according to eMMC spec.
>>> * Define ECSD structure.
>>> * Add interface to set IO bus width and speed.
>>> * Support to access multiple blocks.
>>
>> This is a substantial contribution, and on inspection it looks fine.
>> However, it does change bits of MmcDxe substantially - so I would
>> really like to see some Tested-by:s for existing platforms.
>>
>> Ryan?

I'd love to, but the only platform I have with an MMC card slot is
TC2.  And MMC support as been broken in EDK2 on TC2 for some time.

The last time I saw it working was at this point:

203bead  2015-07-01  There needs to be a space between the output
section name and the colon, i.e.,     [Ard Biesheuvel]

But that point doesn't boot on TC2 unless you revert this patch:

d340ef7  2014-08-26  ArmPkg/ArmArchTimerLib: Remove non required
[depex] and IoLib      [Olivier Martin]

I'll add it to my list of other things someone else broke that I have to fix.


>> Anyone else?
>>
>> Also, to make it easier to test the series - could you push it to a
>> public git repository (presumably git.linaro.org)?
>
>
> This patch series is already in
> https://github.com/96boards-hikey/edk2/commits/hikey-aosp
>
> Best Regards
> Haojian
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to