On 03/01/16 12:54, Ard Biesheuvel wrote: > On 1 March 2016 at 12:51, Laszlo Ersek <[email protected]> wrote: >> On 03/01/16 12:41, Ard Biesheuvel wrote: >>> On 1 March 2016 at 12:34, Shivamurthy Shastri >>> <[email protected]> wrote: >>>> Resolved below errors: >>>> 1. Variable 'gEfiHostnameVariableGuid' used, but not defined GUID. >>>> 2. File 'Hostname.h' is included, but it is not available in source. >>>> >>> >>> Interesting. I suppose this code could never be built from the >>> upstream source since it was merged? Nice. >>> >>> Anyway, since this GUID is used as a scope identifier for the EFI >>> variable holding the hostname, I don't think we need a brand new GUID >>> here. Either gEfiGlobalVariableGuid or gEfiCallerIdGuid (if the >>> variable is considered private to this module) should be sufficient. >> >> the gEfiGlobalVariableGuid namespace allows standardized variables only, >> IIRC >> > > OK, I didn't realize that. In any case, I wonder how this is supposed > to work, since the scope GUID does not exist, and there is no code in > the tree that sets the variable L"Hostname" in any scope. > > So please, let's figure out how this works in theory before papering > over more profound issues by defining missing GUIDs with random > values.
Sure, my first choice is to avoid papering over things as well. Can someone state the problem concisely? Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
