> On Mar 1, 2016, at 3:51 AM, Laszlo Ersek <[email protected]> wrote: > > On 03/01/16 12:41, Ard Biesheuvel wrote: >> On 1 March 2016 at 12:34, Shivamurthy Shastri >> <[email protected]> wrote: >>> Resolved below errors: >>> 1. Variable 'gEfiHostnameVariableGuid' used, but not defined GUID. >>> 2. File 'Hostname.h' is included, but it is not available in source. >>> >> >> Interesting. I suppose this code could never be built from the >> upstream source since it was merged? Nice. >> >> Anyway, since this GUID is used as a scope identifier for the EFI >> variable holding the hostname, I don't think we need a brand new GUID >> here. Either gEfiGlobalVariableGuid or gEfiCallerIdGuid (if the >> variable is considered private to this module) should be sufficient. > > the gEfiGlobalVariableGuid namespace allows standardized variables only, > IIRC >
Yes gEfiGlobalVariableGuid is owned by the UEFI specification and should not be used. Thanks, Andrew Fish >> >> Thanks, >> Ard. >> >> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Shivamurthy Shastri <[email protected]> >>> --- >>> EmbeddedPkg/EmbeddedPkg.dec | 2 ++ >>> EmbeddedPkg/Include/Guid/Hostname.h | 20 ++++++++++++++++++++ >>> 2 files changed, 22 insertions(+) >>> create mode 100644 EmbeddedPkg/Include/Guid/Hostname.h >>> >>> diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec >>> index cd0d96f..2617323 100644 >>> --- a/EmbeddedPkg/EmbeddedPkg.dec >>> +++ b/EmbeddedPkg/EmbeddedPkg.dec >>> @@ -55,6 +55,8 @@ >>> # Include/Guid/FdtHob.h >>> gFdtHobGuid = { 0x16958446, 0x19B7, 0x480B, { 0xB0, 0x47, 0x74, 0x85, >>> 0xAD, 0x3F, 0x71, 0x6D } } >>> gFdtVariableGuid = { 0x25a4fd4a, 0x9703, 0x4ba9, { 0xa1, 0x90, 0xb7, >>> 0xc8, 0x4e, 0xfb, 0x3e, 0x57 } } >>> + # Include/Guid/Hostname.h >>> + gEfiHostnameVariableGuid = { 0xf1851fe8, 0x7d79, 0x43fb, { 0xae, >>> 0x4c, 0x65, 0x7d, 0xd8, 0xd3, 0xc8, 0x80 } } >>> >>> [Protocols.common] >>> gHardwareInterruptProtocolGuid = { 0x2890B3EA, 0x053D, 0x1643, { 0xAD, >>> 0x0C, 0xD6, 0x48, 0x08, 0xDA, 0x3F, 0xF1 } } >>> diff --git a/EmbeddedPkg/Include/Guid/Hostname.h >>> b/EmbeddedPkg/Include/Guid/Hostname.h >>> new file mode 100644 >>> index 0000000..6789d89 >>> --- /dev/null >>> +++ b/EmbeddedPkg/Include/Guid/Hostname.h >>> @@ -0,0 +1,20 @@ >>> +/** @file >>> +* >>> +* Copyright (c) 2015, Linaro Limited. All rights reserved. >>> +* >>> +* This program and the accompanying materials >>> +* are licensed and made available under the terms and conditions of the >>> BSD License >>> +* which accompanies this distribution. The full text of the license may >>> be found at >>> +* http://opensource.org/licenses/bsd-license.php >>> +* >>> +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >>> +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR >>> IMPLIED. >>> +* >>> +**/ >>> + >>> +#ifndef __HOSTNAME_H__ >>> +#define __HOSTNAME_H__ >>> + >>> +extern EFI_GUID gEfiHostnameVariableGuid; >>> + >>> +#endif /* __HOSTNAME_H__ */ >>> -- >>> 1.9.1 >>> >> _______________________________________________ >> edk2-devel mailing list >> [email protected] >> https://lists.01.org/mailman/listinfo/edk2-devel >> > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
