Liming -- At a minimum, yes. The error message currently does not help the user to identify the problem correctly.
Better would be to skip the UTF-8 BOM marker, but complain later if a non-ASCII character shows up. Tim -----Original Message----- From: Gao, Liming [mailto:liming....@intel.com] Sent: Wednesday, March 02, 2016 11:27 PM To: Tim Lewis <tim.le...@insyde.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Subject: RE: BOM in .dec, .dsc, .fdf Tim: So, you suggest to let build tool report the meaning error message if .dec, .dsc, .fdf and .inf are not ASCII files. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Tim Lewis > Sent: Wednesday, March 02, 2016 7:42 AM > To: Kinney, Michael D; edk2-devel@lists.01.org > Subject: Re: [edk2] BOM in .dec, .dsc, .fdf > > Mike -- > > Ok. It's not an EDK2 file, in this case. I suspected that this was > what was happening, since we couldn't find another non-ASCII character. > > The error message (BC0DE) wasn't so helpful, coming back through the > exception handler in build.py. > > Tim > > -----Original Message----- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Tuesday, March 01, 2016 3:33 PM > To: Tim Lewis <tim.le...@insyde.com>; edk2-devel@lists.01.org; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: RE: BOM in .dec, .dsc, .fdf > > Tim, > > Those files types are all required to be ASCII files. > > If one of those files in EDK II repo has UTF-8 BOM, then that is a bug > and needs to be fixed. > > I have seen text editors that auto convert ASCII to UTF-8 if a > non-ASCII character is ever added to a file. The file then retains > the UTF-8 BOM even after the non-ASCII character is removed. You have > to convert the file back to ASCII and save to remove the BOM. > > Mike > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf > > Of Tim Lewis > > Sent: Tuesday, March 1, 2016 3:20 PM > > To: edk2-devel@lists.01.org > > Subject: [edk2] BOM in .dec, .dsc, .fdf > > > > I thought I saw a thread talking about this. We are seeing an issue > > with a UTF-8 BOM appears at the beginning of a .dec file, even if > > there are no other non-ASCII characters. In our case, this causes > > the parser to bomb out with a stack trace. This happens to our users in > > Asia. > > > > I couldn't find anything in the check-in comments, but perhaps I missed it? > > > > Tim > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
