On Thu, 2016-03-17 at 21:28 +0000, Kinney, Michael D wrote: > > Yes. Use of developer github forks is supported. I had summarized > 3 development methods earlier in this thread. > > 1) PR emails send to edk2-devel. There is a Wiki page that details process > for developers and maintainer. > > 2) Branch on developer owned github fork of edk2. There have been > discussions on > how to support a pull request. This is still under investigation. In the > meantime, a link to the branch and pull request can be included in > the PR emails to edk2-devel. > > 3) Branch on edk2-staging (Specific process being discussed in this thread)
Let's *test* my assertion that github PRs should be sufficient even to cover #3. They're discoverable — at https://github.com/tianocore/edk2/pulls you can see that I've just filed a couple of tickets. I believe they satisfies all the other criteria you've mentioned, but let's have an experiment and find out. I think these two test cases are precisely the kind of submission which want to be handled via 'staging', aren't they? The first — https://github.com/tianocore/edk2/pull/70 — is the update to build against OpenSSL 1.1. I've thrown in a "line note" on the code, so you can see how that works as well as the general discussion in the ticket. The second — https://github.com/tianocore/edk2/pull/71 — is a test of converting the internal representation of all files to use git's native LF line endings. This should mean that the tools can do the right thing and check out the working files according to the norms of the platform — you'll get CRLF on Windows, and LF on Linux. It would be good to test that, iron out any problems and get it fixed. But again, definitely something that wants staging for review and testing first. -- David Woodhouse Open Source Technology Centre [email protected] Intel Corporation
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
