On Fri, 2016-03-18 at 13:30 +0100, Laszlo Ersek wrote:
> 
> Our workflow should not be centered on github pull requests in any case,
> so I don't see the point in testing them out. 

Well, thanks for destroying the test I spent this morning setting up,
because you don't believe it would have useful results.

I happen to disagree about using github pull requests. Every change
there triggers an email, and we can set things up so that email is also
copied to the mailing list. So it's just as well-archived as the other
list traffic, and we don't have to worry about github.com disappearing
in a puff of smoke any more than we already did.

> workflow centered on pull requests that are sent to the mailing list
> should be tested out, and I'd like to work with you on that.

That works for me, but doesn't seem to cover the criteria that Michael
set out for discoverability.

> I understand that the PRs you created on github explicitly stated they
> weren't to be merged. It doesn't matter. One misclick from an edk2
> maintainer who happens to be paying a bit less attention, and poof, we
> have mess in the git history.

Which is fairly much true of *any* work, right? Any of those people
could 'accidentally' push stuff from their working tree out to the main
repository, at any time. We either revert it with a new commit, or we
quickly undo the commit and rewind the contents of the tree before too
many people update from it. It's hardly the end of the world.

And the chances of the CRLF conversion one actually *applying* if
someone stupidly hits the button, after *one* more commit hits the
tree, are fairly much zero anyway. So you're defending against an
impossibility in that case.

I don't know if I should be offended on behalf of the maintainers who
are mostly my colleagues, that you have such a low opinion of their
capabilities.

-- 
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to