On 03/21/16 11:14, Ard Biesheuvel wrote:
> On 14 March 2016 at 13:53, Laszlo Ersek <[email protected]> wrote:
>> Cc: Ard Biesheuvel <[email protected]>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <[email protected]>
>> ---
>>
>> Notes:
>> Ard, can you please regression-test the RNG for me? Thanks!
>>
>
> For the series/waves:
>
> Tested-by: Ard Biesheuvel <[email protected]>
>
> and where you need it
>
> Reviewed-by: Ard Biesheuvel <[email protected]>
>
> with the caveat that, other than confirming that everything still
> works as before, I did not try to confirm that 1.0 capable peripherals
> end up being driven in a different way.
Would you find it more precise if I added your T-b as
"Regression-tested-by"? I sometimes employ that tag myself.
For the testing (of RNG, for example), did you add the QEMU properties
,disable-legacy=on,disable-modern=off
? If you didn't add it, then R-t-b is more appropriate. If you did add
it, then T-b is appropriate.
Thank you!
Laszlo
>
>
>> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
>> ArmVirtPkg/ArmVirtQemu.fdf | 1 +
>> ArmVirtPkg/ArmVirtQemuKernel.fdf | 1 +
>> 4 files changed, 4 insertions(+)
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
>> index fafad7751e6d..2bb491fcfe81 100644
>> --- a/ArmVirtPkg/ArmVirtQemu.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
>> @@ -355,14 +355,15 @@ [Components.common]
>>
>> #
>> # PCI support
>> #
>> ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf
>> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
>> + OvmfPkg/Virtio10Dxe/Virtio10.inf
>>
>> #
>> # Video support
>> #
>> OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf {
>> <LibraryClasses>
>> BltLib|OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> index bfa4dbe9fd8c..b33e96f5d7e8 100644
>> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>> @@ -345,14 +345,15 @@ [Components.common]
>>
>> #
>> # PCI support
>> #
>> ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf
>> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
>> + OvmfPkg/Virtio10Dxe/Virtio10.inf
>>
>> #
>> # Video support
>> #
>> OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf {
>> <LibraryClasses>
>> BltLib|OptionRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
>> diff --git a/ArmVirtPkg/ArmVirtQemu.fdf b/ArmVirtPkg/ArmVirtQemu.fdf
>> index ef456539cc62..9d1503cfc7c8 100644
>> --- a/ArmVirtPkg/ArmVirtQemu.fdf
>> +++ b/ArmVirtPkg/ArmVirtQemu.fdf
>> @@ -212,14 +212,15 @@ [FV.FvMain]
>>
>> #
>> # PCI support
>> #
>> INF ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf
>> INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>> INF OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
>> + INF OvmfPkg/Virtio10Dxe/Virtio10.inf
>>
>> #
>> # Video support
>> #
>> INF OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
>> INF OvmfPkg/PlatformDxe/Platform.inf
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.fdf
>> b/ArmVirtPkg/ArmVirtQemuKernel.fdf
>> index 7491f8042bd7..472e0fe810d4 100644
>> --- a/ArmVirtPkg/ArmVirtQemuKernel.fdf
>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.fdf
>> @@ -230,14 +230,15 @@ [FV.FvMain]
>>
>> #
>> # PCI support
>> #
>> INF ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf
>> INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>> INF OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
>> + INF OvmfPkg/Virtio10Dxe/Virtio10.inf
>>
>> #
>> # Video support
>> #
>> INF OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
>> INF OvmfPkg/PlatformDxe/Platform.inf
>>
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> [email protected]
>> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
