On 03/21/16 11:29, Ard Biesheuvel wrote: > On 21 March 2016 at 11:23, Laszlo Ersek <ler...@redhat.com> wrote: >> On 03/21/16 11:14, Ard Biesheuvel wrote: >>> On 14 March 2016 at 13:53, Laszlo Ersek <ler...@redhat.com> wrote: >>>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >>>> --- >>>> >>>> Notes: >>>> Ard, can you please regression-test the RNG for me? Thanks! >>>> >>> >>> For the series/waves: >>> >>> Tested-by: Ard Biesheuvel <ard.biesheu...@linaro.org> >>> >>> and where you need it >>> >>> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> >>> >>> with the caveat that, other than confirming that everything still >>> works as before, I did not try to confirm that 1.0 capable peripherals >>> end up being driven in a different way. >> >> Would you find it more precise if I added your T-b as >> "Regression-tested-by"? I sometimes employ that tag myself. >> >> For the testing (of RNG, for example), did you add the QEMU properties >> >> ,disable-legacy=on,disable-modern=off >> >> ? If you didn't add it, then R-t-b is more appropriate. If you did add >> it, then T-b is appropriate. >> > > OK, that works, at least from the EDK2 side.
Great, thank you! > From the kernel side, I am getting > > [ 0.897114] virtio_rng: probe of virtio2 failed with error -2 > [ 0.975458] virtio_blk: probe of virtio0 failed with error -2 > > which is unlikely to have anything to do with this series (not using > ACPI, since the ACPI PCI support in the arm64 kernel is not upstream > yet) That problem is indeed caused by QEMU. Please see the following in the wave 3 blurb: > If you would like to test this series with VirtIo 1.0 devices, patch > 13 has some instructions about the QEMU command line. If you also want > to boot Linux guests on them, then you will need a fairly recent (4.2 > or 4.3+) guest kernel, *plus* the following (pending) QEMU bugfix: > <http://thread.gmane.org/gmane.comp.emulators.qemu/400142/focus=400161>. The referenced patch ("virtio-pci: call pci reset variant when guest requests reset") is now upstream (75fd6f13af85), but the branch containing it was merged only very recently (after I posted these series): on 2016-03-15. So if your QEMU is older than that, the above Linux error message is expected. Thanks again! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
