Please update the commit log title. It's not a typo. It's a bug which has wrong condition judgment.
Others looks good to me Reviewed-by: Feng Tian <[email protected]> Thanks Feng -----Original Message----- From: Dong, Eric Sent: Thursday, April 7, 2016 9:27 PM To: [email protected] Cc: Tian, Feng <[email protected]> Subject: [Patch] SecurityPkg TcgStorageOpalLib: Fix a typo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong <[email protected]> Cc: Feng Tian <[email protected]> --- SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c index d27a9c9..f77fbe2 100644 --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c @@ -626,7 +626,7 @@ OpalUtilRevert( // Try to revert with admin1 // Ret = OpalAdminRevert(Session, KeepUserData, &MethodStatus); - if (Ret != TcgResultSuccess || MethodStatus == TCG_METHOD_STATUS_CODE_SUCCESS) { + if (Ret != TcgResultSuccess || MethodStatus != TCG_METHOD_STATUS_CODE_SUCCESS) { // // Device ends the session on successful revert, so only call OpalEndSession when fail. // -- 2.6.4.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
