Do you check all files for unnecessary debug message? If not, please update your commit title to show up this change is only for Opalhii.c
Reviewed-by: Feng Tian <[email protected]> Thanks Feng -----Original Message----- From: Dong, Eric Sent: Thursday, April 7, 2016 9:27 PM To: [email protected] Cc: Tian, Feng <[email protected]> Subject: [Patch] SecurityPkg OpalPasswordDxe: Clean up debug message. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong <[email protected]> Cc: Feng Tian <[email protected]> --- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c index 94dce6c..75ff9fc 100644 --- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c +++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c @@ -102,7 +102,6 @@ HiiSetCurrentConfiguration( &DataSize, &OpalExtraInfo ); - DEBUG ((DEBUG_INFO, "GetVariable for OpalExtraInfo @ HiiSetCurrentConfiguration, Status: %r\n", Status)); if (!EFI_ERROR (Status)) { gHiiConfiguration.EnableBlockSid = OpalExtraInfo.EnableBlockSid; } @@ -1110,8 +1109,6 @@ HiiPasswordEntered( UnicodeStrToAsciiStr(UniStr, Password); gBS->FreePool(UniStr); - DEBUG ((DEBUG_INFO, "Password: '%s'\n", Password)); - if (gHiiConfiguration.SelectedAction == HII_KEY_ID_GOTO_UNLOCK) { Status = HiiUnlock (OpalDisk, Password, PassLength); } else if (gHiiConfiguration.SelectedAction == HII_KEY_ID_GOTO_SECURE_ERASE) { @@ -1150,8 +1147,6 @@ HiiSetBlockSid ( Status = EFI_SUCCESS; - DEBUG ((DEBUG_INFO, "HiiSetBlockSid(enable: %x)\n", Enable)); - OpalExtraInfo.EnableBlockSid = Enable; DataSize = sizeof (OPAL_EXTRA_INFO_VAR); Status = gRT->SetVariable ( @@ -1161,7 +1156,6 @@ HiiSetBlockSid ( DataSize, &OpalExtraInfo ); - DEBUG ((DEBUG_INFO, "SetVariable, Status: %r\n", Status)); return Status; } @@ -1192,7 +1186,6 @@ RouteConfig( EFI_STRING *Progress ) { - DEBUG ((DEBUG_INFO, "RouteConfig( )\n")); if (Configuration == NULL || Progress == NULL) { return (EFI_INVALID_PARAMETER); } @@ -1237,8 +1230,6 @@ ExtractConfig( { EFI_STATUS Status; - DEBUG ((DEBUG_INFO, "ExtractConfig( )\n")); - // // Check for valid parameters // @@ -1272,7 +1263,6 @@ OpalHiiSetBrowserData ( VOID ) { - DEBUG ((DEBUG_INFO, "OpalHiiSetBrowserData( )\n")); HiiSetBrowserData( &gHiiSetupVariableGuid, (CHAR16*)L"OpalHiiConfig", @@ -1293,7 +1283,6 @@ OpalHiiGetBrowserData ( VOID ) { - DEBUG ((DEBUG_INFO, "OpalHiiGetBrowserData( )\n")); HiiGetBrowserData( &gHiiSetupVariableGuid, (CHAR16*)L"OpalHiiConfig", @@ -1322,8 +1311,6 @@ HiiSetFormString( UINT32 UniSize; CHAR16* UniStr; - DEBUG ((DEBUG_INFO, "HiiSetFormString( )\n")); - // // Determine the Length of the sting // -- 2.6.4.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
