On Wed, Apr 20, 2016 at 11:06:28AM -0500, Jeremy Linton wrote: > On 04/20/2016 11:00 AM, Sudeep Holla wrote: > > > > > >On 20/04/16 16:54, Sudeep Holla wrote: > >> > >> > >>On 20/04/16 16:44, Jeremy Linton wrote: > >>>On 04/20/2016 10:35 AM, Sudeep Holla wrote: > >>>> > >> > >>[...] > >> > >>>> > >>>>Yes I got bitten by that and I failed to notice it :). I have fixed it > >>>>locally and tested correctly now. > >>>> > >>> > >>>DWordIo ( // IO window > >>> ResourceProducer, > >>> MinFixed, > >>> MaxFixed, > >>> PosDecode, > >>> EntireRange, > >>> 0x00000000, // Granularity > >>> 0x00000000, // Min Base Address > >>> 0x007fffff, // Max Base Address > >>> 0x5f800000, // Translate > >>> 0x00800000, // Length > >>> , > >>> , > >>> , > >> > >>This is exactly what I have now after fixing the length and works fine, > >>but ... > >> > >>> TypeTranslation > >> > >>... this is TypeStatic which I assume is default when not specified. > >> > >>I tried TypeTranslation too and it works fine. It adds DenseTranslation > >>by default. Do you want me to add TypeTranslation? > >> > > > >I must have seen spec before replying to you :( It states: > > > >"TranslationType is an optional argument that specifies whether the > >resource type on the secondary side of the bus is different > >(TypeTranslation) from that on the primary side of the bus or the same > >(TypeStatic). If TypeTranslation is specified, then the secondary side > >of the bus is Memory. If TypeStatic is specified, then the secondary > >side of the bus is I/O. If nothing is specified, then TypeStatic is > >assumed." > > See table 6-214, it disagrees. Also older spec's seem to say something > different. > >
>From memory the conclusion on ASWG was that TypeTranslation was correct but it was so misused in past due to misleading spec that most OSes ignore it. Graeme _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
