Reviewed-by: Ruiyu Ni <ruiyu...@intel.com>

Thanks for the detailed comments. They do help people to understand
the differences between old and new BDS.

Regards,
Ray

>-----Original Message-----
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Friday, May 6, 2016 3:22 AM
>To: edk2-devel-01 <edk2-de...@ml01.01.org>
>Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Ni, Ruiyu <ruiyu...@intel.com>
>Subject: [PATCH 00/13] ArmVirtPkg: move to MdeModulePkg BDS
>
>Based on Ray's recent patches for OvmfPkg, and what I learned from them.
>
>Fixes: <https://github.com/tianocore/edk2/issues/83>.
>
>Public branch:
><https://github.com/lersek/edk2/commits/armvirt_core_bds_issue83>.
>
>I'm CC'ing Ray on the entire series -- I'm not asking for a in-depth
>code validation (ain't nobody got time for that, probably :)), but a
>quick verification of the commit messages would be very welcome.
>
>Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
>Cc: Ruiyu Ni <ruiyu...@intel.com>
>
>Thanks!
>Laszlo
>
>Laszlo Ersek (13):
>  ArmVirtPkg: duplicate PlatformIntelBdsLib to PlatformBootManagerLib
>  ArmVirtPkg/PlatformBootManagerLib: follow PlatformBootManagerLib
>    interfaces
>  ArmVirtPkg/PlatformBootManagerLib: use
>    EfiBootManagerUpdateConsoleVariable
>  ArmVirtPkg/PlatformBootManagerLib: link against UefiBootManagerLib
>  ArmVirtPkg/PlatformBootManagerLib: init console vars in
>    BeforeConsole()
>  ArmVirtPkg/PlatformBootManagerLib: don't launch the Boot Manager Menu
>  ArmVirtPkg/PlatformBootManagerLib: register boot options and hot keys
>  ArmVirtPkg/PlatformBootManagerLib: remove empty PlatformBdsLib hooks
>  ArmVirtPkg/PlatformBootManagerLib: use UefiBootManagerLib ConnectAll()
>    API
>  ArmVirtPkg/PlatformBootManagerLib: rebase boot order manipulation
>  ArmVirtPkg/PlatformBootManagerLib: add EnableQuietBoot &
>    DisableQuietBoot
>  ArmVirtPkg/ArmVirtQemu: use MdeModulePkg/BDS
>  ArmVirtPkg: retire PlatformIntelBdsLib
>
> ArmVirtPkg/ArmVirt.dsc.inc
>|   7 +-
> ArmVirtPkg/ArmVirtQemu.dsc
>|  20 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc
>|  20 +-
> ArmVirtPkg/ArmVirtQemu.fdf
>|   3 +-
> ArmVirtPkg/ArmVirtQemuKernel.fdf
>|   3 +-
> ArmVirtPkg/Library/{PlatformIntelBdsLib/PlatformIntelBdsLib.inf => 
> PlatformBootManagerLib/PlatformBootManagerLib.inf}
>|  23 +-
> ArmVirtPkg/Library/{PlatformIntelBdsLib/IntelBdsPlatform.h => 
> PlatformBootManagerLib/PlatformBm.h}
>|  42 ++-
> ArmVirtPkg/Library/{PlatformIntelBdsLib/IntelBdsPlatform.c => 
> PlatformBootManagerLib/PlatformBm.c}
>| 270 +++++++++++++-------
> ArmVirtPkg/Library/{PlatformIntelBdsLib => 
> PlatformBootManagerLib}/QemuKernel.c
>|   4 +-
> {OvmfPkg => ArmVirtPkg}/Library/PlatformBootManagerLib/QuietBoot.c
>|   9 +-
> 10 files changed, 266 insertions(+), 135 deletions(-)
> rename ArmVirtPkg/Library/{PlatformIntelBdsLib/PlatformIntelBdsLib.inf =>
>PlatformBootManagerLib/PlatformBootManagerLib.inf} (72%)
> rename ArmVirtPkg/Library/{PlatformIntelBdsLib/IntelBdsPlatform.h => 
> PlatformBootManagerLib/PlatformBm.h} (62%)
> rename ArmVirtPkg/Library/{PlatformIntelBdsLib/IntelBdsPlatform.c => 
> PlatformBootManagerLib/PlatformBm.c} (62%)
> rename ArmVirtPkg/Library/{PlatformIntelBdsLib => 
> PlatformBootManagerLib}/QemuKernel.c (96%)
> copy {OvmfPkg => ArmVirtPkg}/Library/PlatformBootManagerLib/QuietBoot.c (95%)
>
>--
>1.8.3.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to