I think you are right. Could you help contribute the patch to fix it?
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:[email protected]] On Behalf Of wang
xiaofeng
Sent: Friday, May 13, 2016 10:20 AM
To: [email protected]
Subject: [edk2] a minor logic error in
PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
Hi Everyone ,
Please refer to the code in AcpiTimerLibConstructor in
PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c
The orginal code is
if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister) &
EnableMask) != EnableMask)) {
The bracket place is not right, I think it should be
if ((PciRead8 (PCI_LIB_ADDRESS (Bus, Device, Function, EnableRegister)) &
EnableMask) != EnableMask)
Anyhow , the impact is minor since it will enable ACPI I/O base again.
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
