Looks good to me. Reviewed-by: Giri P Mudusuru <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:54 AM > To: [email protected] > Subject: [edk2] [Patch 1/2] PcAtChipsetPkg: Add two PCDs for Reset Control > Register and Value > > PcdResetControlRegister for Reset Control Register address. > PcdResetControlValueColdReset for Reset Control Register code reset value. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao <[email protected]> > --- > PcAtChipsetPkg/PcAtChipsetPkg.dec | 8 ++++++++ > PcAtChipsetPkg/PcAtChipsetPkg.uni | 15 +++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec > b/PcAtChipsetPkg/PcAtChipsetPkg.dec > index cbd5707..b0b2b62 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.dec > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec > @@ -173,5 +173,13 @@ > # @Prompt ACPI IO Port Base Address Mask > gPcAtChipsetPkgTokenSpaceGuid.PcdAcpiIoPortBaseAddressMask > |0xFFFE|UINT16|0x00000018 > > + ## Reset Control Register address in I/O space. > + # @Prompt Reset Control Register address > + > gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlRegister|0x64|UINT64|0x00 > 000019 > + > + ## 8bit Reset Control Register value for cold reset. > + # @Prompt Reset Control Register value for cold reset > + > gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlValueColdReset|0xFE|UINT8 > |0x0000001A > + > [UserExtensions.TianoCore."ExtraFiles"] > PcAtChipsetPkgExtra.uni > diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.uni > b/PcAtChipsetPkg/PcAtChipsetPkg.uni > index 87f9396..530e9ae 100644 > --- a/PcAtChipsetPkg/PcAtChipsetPkg.uni > +++ b/PcAtChipsetPkg/PcAtChipsetPkg.uni > @@ -141,3 +141,18 @@ > > #string STR_gPcAtChipsetPkgTokenSpaceGuid_ERR_80000001 #language en-US > "Invalid value provided." > > +#string > STR_gPcAtChipsetPkgTokenSpaceGuid_PcdResetControlRegister_PROMPT > +#language en-US > +"Reset Control Register address" > + > +#string STR_gPcAtChipsetPkgTokenSpaceGuid_PcdResetControlRegister_HELP > +#language en-US > +"Reset Control Register address in I/O space." > + > +#string > STR_gPcAtChipsetPkgTokenSpaceGuid_PcdResetControlValueColdReset_PROM > PT > +#language en-US > +"Reset Control Register value for cold reset" > + > +#string > STR_gPcAtChipsetPkgTokenSpaceGuid_PcdResetControlValueColdReset_HELP > +#language en-US > +"8bit Reset Control Register value for cold reset." > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
