Looks good to me. Can you also use the PCD control for Warm and add new PCD for warm reset value in separate patch?
Reviewed-by: Giri P Mudusuru <[email protected]> Thanks, -Giri > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of > Liming Gao > Sent: Thursday, June 23, 2016 2:54 AM > To: [email protected] > Subject: [edk2] [Patch 2/2] PcAtChipsetPkg: Update ResetSystemLib with PCDs > > Update ResetSystemLib with PCDs for Reset Control Register and Value > instead of hard code 0x64 and 0xFE. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao <[email protected]> > --- > PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c | 6 +++--- > PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.inf | 6 +++++- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c > b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c > index 6a9dd71..b3b2efb 100644 > --- a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c > +++ b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.c > @@ -1,7 +1,7 @@ > /** @file > Reset System Library functions for PCAT platforms > > - Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found > at > @@ -32,7 +32,7 @@ ResetCold ( > VOID > ) > { > - IoWrite8 (0x64, 0xfe); > + IoWrite8 ((UINTN) PcdGet64 (PcdResetControlRegister), PcdGet8 > (PcdResetControlValueColdReset)); > } > > /** > @@ -48,7 +48,7 @@ ResetWarm ( > VOID > ) > { > - IoWrite8 (0x64, 0xfe); > + IoWrite8 ((UINTN) PcdGet64 (PcdResetControlRegister), PcdGet8 > (PcdResetControlValueColdReset)); > } > > /** > diff --git a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.inf > b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.inf > index c994827..2384efa 100644 > --- a/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.inf > +++ b/PcAtChipsetPkg/Library/ResetSystemLib/ResetSystemLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Library instance for ResetSystem library class for PCAT systems > # > -# Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD > License > # which accompanies this distribution. The full text of the license may be > found > at > @@ -32,8 +32,12 @@ > > [Packages] > MdePkg/MdePkg.dec > + PcAtChipsetPkg/PcAtChipsetPkg.dec > > [LibraryClasses] > DebugLib > IoLib > > +[Pcd] > + gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlRegister ## CONSUMES > + gPcAtChipsetPkgTokenSpaceGuid.PcdResetControlValueColdReset ## > CONSUMES > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
