On Wed, Jul 27, 2016 at 01:43:30AM +0000, Wei, David wrote: > Hi Gary, > Hi David,
> Could you double check if this whole logic unit can be removed together? If > possible, should remove all of them. > > // > // Get Platform Info HOB > // > Hob.Raw = GetFirstGuidHob (&gEfiPlatformCpuInfoGuid); > ASSERT (Hob.Raw != NULL); > PlatformCpuInfo = GET_GUID_HOB_DATA(Hob.Raw); > Yeah, I didn't notice the usage of Hob. The variable is also not really used later. Will remove that in v2. Thanks, Gary Lin > Reviewed-by: David Wei <david....@intel.com> > > > Thanks, > David Wei > > Intel SSG BIOS Team > > > -----Original Message----- > From: Gary Lin [mailto:g...@suse.com] > Sent: Tuesday, July 26, 2016 3:18 PM > To: edk2-devel@lists.01.org > Cc: Wei, David <david....@intel.com>; Tim He <tim...@intel.com> > Subject: [PATCH 06/19] Vlv2TbltDevicePkg/PlatformInitPei: Remove the unused > variables > > Fix the following errors from gcc: > > Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c: In function 'IchRcrbInit': > Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c:513:36: error: variable > 'PlatformCpuInfo' set but not used [-Werror=unused-but-set-variable] > Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c:512:35: error: variable > 'LpcRevisionID' set but not used [-Werror=unused-but-set-variable] > > Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c: In function > 'EndOfPeiPpiNotifyCallback': > Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c:64:31: error: variable > 'MemoryTop' set but not used [-Werror=unused-but-set-variable] > > Cc: David Wei <david....@intel.com> > Cc: Tim He <tim...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin <g...@suse.com> > --- > Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c | 2 -- > Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c | 5 ----- > 2 files changed, 7 deletions(-) > > diff --git a/Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c > b/Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c > index 31cc88a..9d9c0e5 100644 > --- a/Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c > +++ b/Vlv2TbltDevicePkg/PlatformInitPei/MemoryCallback.c > @@ -52,7 +52,6 @@ EndOfPeiPpiNotifyCallback ( > ) > { > EFI_STATUS Status; > - UINT64 MemoryTop; > UINT64 LowUncableBase; > EFI_PLATFORM_INFO_HOB *PlatformInfo; > UINT32 HecBaseHigh; > @@ -100,7 +99,6 @@ EndOfPeiPpiNotifyCallback ( > > LowUncableBase = PlatformInfo->MemData.MemMaxTolm; > LowUncableBase &= (0x0FFF00000); > - MemoryTop = (0x100000000); > > if (BootMode != BOOT_ON_S3_RESUME) { > // > diff --git a/Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c > b/Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c > index 30f87c1..6ad339d 100644 > --- a/Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c > +++ b/Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c > @@ -500,8 +500,6 @@ IchRcrbInit ( > IN SYSTEM_CONFIGURATION *SystemConfiguration > ) > { > - UINT8 LpcRevisionID; > - EFI_PLATFORM_CPU_INFO *PlatformCpuInfo; > EFI_PEI_HOB_POINTERS Hob; > EFI_BOOT_MODE BootMode; > > @@ -510,7 +508,6 @@ IchRcrbInit ( > // > Hob.Raw = GetFirstGuidHob (&gEfiPlatformCpuInfoGuid); > ASSERT (Hob.Raw != NULL); > - PlatformCpuInfo = GET_GUID_HOB_DATA(Hob.Raw); > > (*PeiServices)->GetBootMode(PeiServices, &BootMode); > > @@ -530,8 +527,6 @@ IchRcrbInit ( > // > // Initial RCBA according to the PeiRCBA table > // > - LpcRevisionID = PchLpcPciCfg8 (R_PCH_LPC_RID_CC); > - > if ((BootMode == BOOT_ON_S3_RESUME)) { > // > // We are resuming from S3 > -- > 2.9.2 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
