Reviewed-by: David Wei <david....@intel.com>
Thanks, David Wei Intel SSG BIOS Team -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Tuesday, July 26, 2016 3:18 PM To: edk2-devel@lists.01.org Cc: Tim He <tim...@intel.com>; Wei, David <david....@intel.com> Subject: [edk2] [PATCH 07/19] Vlv2TbltDevicePkg/PlatformInitPei: Suppress the gcc error message Fix the following error from gcc: Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c: In function 'GetWakeupEventAndSaveToHob': Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c:147:11: error: variable 'WakeEventData' set but not used [-Werror=unused-but-set-variable] Although the function name is "GetWakeupEventAndSaveToHob", WakeEventData was never really used or passed to any other function. Given the fact that the function is served as an example, it'd better to keep the code related to WakeEventData. Just add a debug statement to suppress the error message. Cc: David Wei <david....@intel.com> Cc: Tim He <tim...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin <g...@suse.com> --- Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c b/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c index 6e2d592..cbfe78d 100644 --- a/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c +++ b/Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c @@ -157,6 +157,7 @@ GetWakeupEventAndSaveToHob ( } DEBUG ((EFI_D_ERROR, "ACPI Wake Status Register: %04x\n", Pm1Sts)); + DEBUG ((EFI_D_ERROR, "ACPI Wake Event Data: %02x\n", WakeEventData)); return EFI_SUCCESS; } -- 2.9.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel