On Wed, Jul 27, 2016 at 02:14:46AM +0000, Wei, David wrote: > Hi Gary, > > Could you directly include #include <Library/UefiBootServicesTableLib.h> to > fix this bug? > Ok. Including the header file improves the readability of the code a lot. Thanks for the suggestion!
Gary Lin > > Thanks, > David Wei > > Intel SSG BIOS Team > > > -----Original Message----- > From: Gary Lin [mailto:g...@suse.com] > Sent: Tuesday, July 26, 2016 3:18 PM > To: edk2-devel@lists.01.org > Cc: Wei, David <david....@intel.com>; Tim He <tim...@intel.com> > Subject: [PATCH 10/19] Vlv2TbltDevicePkg/PlatformGopPolicy: Declare gBS as > extern > > The variable is already defined in > MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.c > > Cc: David Wei <david....@intel.com> > CC: Tim He <tim...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Gary Lin <g...@suse.com> > --- > Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c > b/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c > index 0abe1b2..4b498f7 100644 > --- a/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c > +++ b/Vlv2TbltDevicePkg/PlatformGopPolicy/PlatformGopPolicy.c > @@ -25,7 +25,7 @@ Copyright (c) 1999 - 2014, Intel Corporation. All rights > reserved > #include <SetupMode.h> > #include <Library/UefiRuntimeServicesTableLib.h> > > -EFI_BOOT_SERVICES *gBS; > +extern EFI_BOOT_SERVICES *gBS; > > > PLATFORM_GOP_POLICY_PROTOCOL mPlatformGOPPolicy; > -- > 2.9.2 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
