Reviewed-by: Giri P Mudusuru <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Ni, > Ruiyu > Sent: Wednesday, July 27, 2016 10:11 PM > To: Zeng, Star <[email protected]>; [email protected] > Cc: Chan, Amy <[email protected]>; Dong, Eric <[email protected]>; Fan, > Jeff <[email protected]> > Subject: Re: [edk2] [PATCH 1/3] IntelFrameworkModulePkg BdsDxe: Use > definition in IndustryStandard/Smbios.h > > > > Reviewed-by: Ruiyu Ni <[email protected]> > > -----Original Message----- > > From: Zeng, Star > > Sent: Thursday, July 28, 2016 11:04 AM > > To: [email protected] > > Cc: Zeng, Star <[email protected]>; Ni, Ruiyu <[email protected]>; Dong, > > Eric <[email protected]>; Fan, Jeff <[email protected]>; Chan, Amy > > <[email protected]> > > Subject: [PATCH 1/3] IntelFrameworkModulePkg BdsDxe: Use definition in > > IndustryStandard/Smbios.h > > > > Cc: Ruiyu Ni <[email protected]> > > Cc: Eric Dong <[email protected]> > > Cc: Jeff Fan <[email protected]> > > Cc: Amy Chan <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Star Zeng <[email protected]> > > --- > > IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c > > b/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c > > index fc8e50f1450e..c771974ca0d2 100644 > > --- a/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c > > +++ b/IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c > > @@ -747,7 +747,7 @@ UpdateFrontPageStrings ( > > SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED; > > Status = Smbios->GetNext (Smbios, &SmbiosHandle, NULL, &Record, > > NULL); > > while (!EFI_ERROR(Status)) { > > - if (Record->Type == EFI_SMBIOS_TYPE_BIOS_INFORMATION) { > > + if (Record->Type == SMBIOS_TYPE_BIOS_INFORMATION) { > > Type0Record = (SMBIOS_TABLE_TYPE0 *) Record; > > StrIndex = Type0Record->BiosVersion; > > GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type0Record + > > Type0Record->Hdr.Length), StrIndex, &NewString); @@ -756,7 +756,7 @@ > > UpdateFrontPageStrings ( > > FreePool (NewString); > > } > > > > - if (Record->Type == EFI_SMBIOS_TYPE_SYSTEM_INFORMATION) { > > + if (Record->Type == SMBIOS_TYPE_SYSTEM_INFORMATION) { > > Type1Record = (SMBIOS_TABLE_TYPE1 *) Record; > > StrIndex = Type1Record->ProductName; > > GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type1Record + > > Type1Record->Hdr.Length), StrIndex, &NewString); @@ -765,7 +765,7 @@ > > UpdateFrontPageStrings ( > > FreePool (NewString); > > } > > > > - if (Record->Type == EFI_SMBIOS_TYPE_PROCESSOR_INFORMATION) { > > + if (Record->Type == SMBIOS_TYPE_PROCESSOR_INFORMATION) { > > Type4Record = (SMBIOS_TABLE_TYPE4 *) Record; > > StrIndex = Type4Record->ProcessorVersion; > > GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type4Record + > > Type4Record->Hdr.Length), StrIndex, &NewString); @@ -774,7 +774,7 @@ > > UpdateFrontPageStrings ( > > FreePool (NewString); > > } > > > > - if (Record->Type == EFI_SMBIOS_TYPE_PROCESSOR_INFORMATION) { > > + if (Record->Type == SMBIOS_TYPE_PROCESSOR_INFORMATION) { > > Type4Record = (SMBIOS_TABLE_TYPE4 *) Record; > > ConvertProcessorToString(Type4Record->CurrentSpeed, 6, &NewString); > > TokenToUpdate = STRING_TOKEN (STR_FRONT_PAGE_CPU_SPEED); > > @@ -782,7 +782,7 @@ UpdateFrontPageStrings ( > > FreePool (NewString); > > } > > > > - if ( Record->Type == > > EFI_SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) { > > + if ( Record->Type == > > SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) { > > Type19Record = (SMBIOS_TABLE_TYPE19 *) Record; > > if (Type19Record->StartingAddress != 0xFFFFFFFF ) { > > InstalledMemory += RShiftU64(Type19Record->EndingAddress - > > -- > > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
