Reviewed-by: Giri P Mudusuru <[email protected]>
> -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Ni, > Ruiyu > Sent: Wednesday, July 27, 2016 10:11 PM > To: Zeng, Star <[email protected]>; [email protected] > Cc: Tian, Feng <[email protected]>; Chan, Amy <[email protected]>; > Dong, Eric <[email protected]> > Subject: Re: [edk2] [PATCH 2/3] MdeModulePkg UiApp: Use definition in > IndustryStandard/Smbios.h > > > > Reviewed-by: Ruiyu Ni <[email protected]> > > -----Original Message----- > > From: Zeng, Star > > Sent: Thursday, July 28, 2016 11:04 AM > > To: [email protected] > > Cc: Zeng, Star <[email protected]>; Ni, Ruiyu <[email protected]>; Dong, > > Eric <[email protected]>; Tian, Feng <[email protected]>; Chan, Amy > > <[email protected]> > > Subject: [PATCH 2/3] MdeModulePkg UiApp: Use definition in > > IndustryStandard/Smbios.h > > > > Cc: Ruiyu Ni <[email protected]> > > Cc: Eric Dong <[email protected]> > > Cc: Feng Tian <[email protected]> > > Cc: Amy Chan <[email protected]> > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Star Zeng <[email protected]> > > --- > > MdeModulePkg/Application/UiApp/FrontPage.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c > > b/MdeModulePkg/Application/UiApp/FrontPage.c > > index aef0e79124de..bda5ff9231b9 100644 > > --- a/MdeModulePkg/Application/UiApp/FrontPage.c > > +++ b/MdeModulePkg/Application/UiApp/FrontPage.c > > @@ -579,7 +579,7 @@ UpdateFrontPageBannerStrings ( > > SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED; > > Status = Smbios->GetNext (Smbios, &SmbiosHandle, NULL, &Record, NULL); > > while (!EFI_ERROR(Status)) { > > - if (Record->Type == EFI_SMBIOS_TYPE_BIOS_INFORMATION) { > > + if (Record->Type == SMBIOS_TYPE_BIOS_INFORMATION) { > > Type0Record = (SMBIOS_TABLE_TYPE0 *) Record; > > StrIndex = Type0Record->BiosVersion; > > GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type0Record + > > Type0Record->Hdr.Length), StrIndex, &NewString); @@ -597,7 +597,7 @@ > > UpdateFrontPageBannerStrings ( > > } > > } > > > > - if (Record->Type == EFI_SMBIOS_TYPE_SYSTEM_INFORMATION) { > > + if (Record->Type == SMBIOS_TYPE_SYSTEM_INFORMATION) { > > Type1Record = (SMBIOS_TABLE_TYPE1 *) Record; > > StrIndex = Type1Record->ProductName; > > GetOptionalStringByIndex ((CHAR8*)((UINT8*)Type1Record + > > Type1Record->Hdr.Length), StrIndex, &NewString); @@ -606,7 +606,7 @@ > > UpdateFrontPageBannerStrings ( > > FreePool (NewString); > > } > > > > - if ((Record->Type == EFI_SMBIOS_TYPE_PROCESSOR_INFORMATION) > > && !FoundCpu) { > > + if ((Record->Type == SMBIOS_TYPE_PROCESSOR_INFORMATION) && > > + !FoundCpu) { > > Type4Record = (SMBIOS_TABLE_TYPE4 *) Record; > > // > > // The information in the record should be only valid when the CPU > > Socket is populated. > > @@ -627,7 +627,7 @@ UpdateFrontPageBannerStrings ( > > } > > } > > > > - if ( Record->Type == > > EFI_SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) { > > + if ( Record->Type == > > SMBIOS_TYPE_MEMORY_ARRAY_MAPPED_ADDRESS ) { > > Type19Record = (SMBIOS_TABLE_TYPE19 *) Record; > > if (Type19Record->StartingAddress != 0xFFFFFFFF ) { > > InstalledMemory += RShiftU64(Type19Record->EndingAddress - > > -- > > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
