On 2016-08-10 19:43:03, Ni, Ruiyu wrote: > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Jordan Justen > > > > On 2016-08-09 22:56:11, Ruiyu Ni wrote: > > > + indicate the reason for the system > > > reset. ResetData is only > > > + valid if ResetStatus is something other > > > than EFI_SUCCESS > > > + unless the ResetType is > > > EfiResetPlatformSpecific > > > + where a minimum amount of ResetData is > > > always > > required. > > > > Most of the patches in this series have lines that are longer than 80 > > columns. > > Can you fix that? > > Do we have rule to limit the line to 80 columns? I saw many files have long > lines. > Or I can change OvmfPkg changes to follow the 80 rule. What do you think?
Yes, it is in the code style document. You should update all patches for it. It looks like most of them will just be copy/paste. > > > > > I think you should move patch 11 before patch 09 "OvmfPkg: Use > > MdeModulePkg/ResetSystemRuntimeDxe". I think this should allow reset to > > continue working through the entire series for OVMF. (right?) > > Reset works using my current order. > But I agree moving #11 before #9 can move ResetPlatformSpecific support > earilier, and group the ResetPlatformSpecific patches together. I will do > that. Oh, I see. I guess this patch updates the ResetPlatformSpecific type, so it probably won't be too important for OVMF. I think it might be a little better earlier, but you can decide if you want to move it or not. -Jordan _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
