Do you need directly assert in ResetPlatformSpecific() for this NULL instance? Other series look good to me
Reviewed-by: Feng Tian <[email protected]> Thanks Feng -----Original Message----- From: Ni, Ruiyu Sent: Wednesday, August 10, 2016 1:56 PM To: [email protected] Cc: Tian, Feng <[email protected]>; Chan, Amy <[email protected]> Subject: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni <[email protected]> Cc: Feng Tian <[email protected]> Cc: Amy Chan <[email protected]> --- .../BaseResetSystemLibNull.c | 23 +++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c index d21a774..b233254 100644 --- a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c +++ b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull +++ .c @@ -1,7 +1,7 @@ /** @file Null Reset System Library instance that only generates ASSERT() conditions. - Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2006 - 2016, Intel Corporation. All rights + reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -77,3 +77,24 @@ EnterS3WithImmediateWake ( { ASSERT (FALSE); } + +/** + This function causes a systemwide reset. The exact type of the reset +is defined + by the EFI_GUID that follows the Null-terminated Unicode string passed into ResetData. + If the platform does not recognize the EFI_GUID in ResetData the +platform must pick a + supported reset type to perform.The platform may optionally log the +parameters from + any non-normal reset that occurs. + + @param[in] DataSize The size, in bytes, of ResetData. + @param[in] ResetData The data buffer starts with a Null-terminated string, followed + by the EFI_GUID. +**/ +VOID +EFIAPI +ResetPlatformSpecific ( + IN UINTN DataSize, + IN VOID *ResetData + ) +{ + ResetCold (); +} -- 2.9.0.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
