Jordan I got error from BaseTools\Scripts\PatchCheck.py, if I add it. Can you fix the tool to remove such limitation?
======================= Checking patch file: C:\home\EdkIITransition\AllComboGit\edk2\0001-Maintainers.t xt-Add-Giri-as-2nd-maintainer-to-IntelF.patch The commit message format is not valid: * First line of commit message (subject line) is too long. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The code passed all checks. ======================= From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Wednesday, September 7, 2016 3:09 PM To: Yao, Jiewen <jiewen....@intel.com>; edk2-devel@lists.01.org Cc: Chan, Amy <amy.c...@intel.com> Subject: Re: [edk2] [PATCH] Maintainers.txt: Add Giri as 2nd maintainer What about this patch subject instead? Maintainers.txt: Add Giri as IntelFsp2*Pkg, IntelSiliconPkg maintainer This way we can see the affected packages from the subject line. -Jordan On 2016-09-06 18:21:10, Jiewen Yao wrote: > Add Giri as 2nd maintainer to IntelFsp2*Pkg and IntelSiliconPkg. > > Cc: Giri P Mudusuru > <giri.p.mudus...@intel.com<mailto:giri.p.mudus...@intel.com>> > Cc: Amy Chan <amy.c...@intel.com<mailto:amy.c...@intel.com>> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao <jiewen....@intel.com<mailto:jiewen....@intel.com>> > --- > Maintainers.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index b2e679d..6ac7085 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -130,10 +130,12 @@ M: Jeff Fan > <jeff....@intel.com<mailto:jeff....@intel.com>> > IntelFsp2Pkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFsp2Pkg > M: Jiewen Yao <jiewen....@intel.com<mailto:jiewen....@intel.com>> > +M: Giri P Mudusuru > <giri.p.mudus...@intel.com<mailto:giri.p.mudus...@intel.com>> > > IntelFsp2WrapperPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFsp2WrapperPkg > M: Jiewen Yao <jiewen....@intel.com<mailto:jiewen....@intel.com>> > +M: Giri P Mudusuru > <giri.p.mudus...@intel.com<mailto:giri.p.mudus...@intel.com>> > > IntelFspPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg > @@ -146,6 +148,7 @@ M: Jiewen Yao > <jiewen....@intel.com<mailto:jiewen....@intel.com>> > IntelSiliconPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelSiliconPkg > M: Jiewen Yao <jiewen....@intel.com<mailto:jiewen....@intel.com>> > +M: Giri P Mudusuru > <giri.p.mudus...@intel.com<mailto:giri.p.mudus...@intel.com>> > > MdeModulePkg > W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg > -- > 2.7.4.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
