On 2016-09-07 10:49:21, Ard Biesheuvel wrote: > On 7 September 2016 at 18:39, Jordan Justen <[email protected]> wrote: > > > > If it is difficult to make a good short subject > > line, then it might be a sign that the patch should be split. For > > example, you could split this patch in 2. One for IntelFsp2*Pkg, and > > another for IntelSiliconPkg. (After all, they are 2 separate package > > types, so it is reasonable to change them separately.) > > > > Please no. It is outright ridiculous to split a maintainer update > patch that adds the same person to two packages into two patches, only > because the subject line becomes too long otherwise. We are not > changing code here, things are not becoming easier to understand by > doing so, and 'making the tool happy' is the worst reason I can think > of to change a perfectly good patch.
We're not trying to make a tool happy. We're trying to use the tool to help write better patches. Also, it is not like splitting it is difficult. If 5 packages are being updated, I want it to be clear in the subject line which packages are being updated. And, yet, I don't want the subject line length to grow far too long just because many packages are being changed. It does seem like in this case, my proposed subject line captures all the pacakges in one commit and is short enough. Personally, I don't really care to see the person's name in the subject line for package maintainer changes. Based on the subject line, if I'm interested in the package, then I can look at the patch to see who is being added/deleted. -Jordan _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
