Hi Felix, Add my comments below.
> -----Original Message----- > From: Felix Poludov [mailto:[email protected]] > Sent: Friday, October 28, 2016 9:52 PM > To: Dong, Eric; [email protected] > Cc: Gao, Liming; Bi, Dandan > Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp > > Hi Eric, > > My goal is to facilitate CreatePopUp customization. > Since UI is one of the most customizable areas in the firmware projects, an > ability to easily replace UI element would be useful. > Thank you for providing the presentation. > I agree with the problem statement. It describes some of the reasons behind > my request. > As far as the solution you propose, you are introducing a new function > HiiGetUserSelection, which is more powerful, but still implements a > specific look-and-feel. > So it should be possible to easily replace HiiGetUserSelection with a project > specific version to align implementation with project-specific > UI. > Which library class are you planning to add HiiGetUserSelection to? [[Eric]] I plan to add this API to HiiLib which existed at MdeModulePkg/Library/UefiHiiLib. I think it's belong to HII scope. > Another question is, what are you planning to do with the existing > CreatePopUp function? [[Eric]] I plan to not change it. Just suggest user to use new API and deprecated it later. > If you just remove it, existing projects that use the function will break. > With my proposal, CreatePopUp can be easily replaced by picking a different > library instance. > For example, we can have a legacy instance that implements current behavior > as well as and advanced instance that implements popup > using HII infrastructure. > > Thanks > Felix > > -----Original Message----- > From: Dong, Eric [mailto:[email protected]] > Sent: Thursday, October 27, 2016 10:36 PM > To: Felix Poludov; [email protected] > Cc: Gao, Liming; Bi, Dandan > Subject: RE: [RFC] [MdePkg] UefiLib: CreatePopUp > > Hi Felix, > > Do you want to provide a new solution for CreatePopup or just want to split > CreatePopup from UefiLib? We already has a proposal to > provide new API to replace CreatePopup. This new API will use modal form to > paint the UI. Detail you can see the proposal in below link: > https://github.com/ydong10/doc/blob/master/Use%20Modal%20form%20for%20CreatePopup%20API.pptx > > Thanks, > Eric > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Felix Poludov > > Sent: Friday, October 28, 2016 5:12 AM > > To: [email protected] > > Subject: [edk2] [RFC] [MdePkg] UefiLib: CreatePopUp > > > > UefiLib library class (MdePkg ) includes CreatePopUp function. > > The function displays a message box. > > There is certainly more than one way to draw a message box. > > If homogenous user interface is a project requirement, > > CreatePopUp is likely to be overridden to align message box appearance with > > the platform look and feel. > > The function can be overridden by creating a project specific UefiLib > > instance, but this seems like an overkill > > because the rest of the UefiLib, which is quite big, would have to be > > duplicated. > > > > One way to solve the problem is to move CreatePopUp to a new library class, > > however, this may break existing projects. > > I suggest changing CreatePopUp implementation to delegate pop up drawing to > > a new > > function UiCreatePopUp provided by a new library class UiLib.h. > > > > I would like to solicit feedback for this proposal. > > If there will be no major objections, I'll start working on a patch. > > > > Thanks > > Felix > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and > > proprietary to American Megatrends, Inc. This communication is > > intended to be read only by the individual or entity to whom it is > > addressed or by their designee. If the reader of this message is not the > > intended recipient, you are on notice that any distribution of this > > message, in any form, is strictly prohibited. Please promptly notify the > > sender by reply e-mail or by telephone at 770-246-8600, and then delete or > > destroy all copies of the transmission. > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > https://lists.01.org/mailman/listinfo/edk2-devel > > Please consider the environment before printing this email. > > The information contained in this message may be confidential and proprietary > to American Megatrends, Inc. This communication is > intended to be read only by the individual or entity to whom it is addressed > or by their designee. If the reader of this message is not the > intended recipient, you are on notice that any distribution of this message, > in any form, is strictly prohibited. Please promptly notify the > sender by reply e-mail or by telephone at 770-246-8600, and then delete or > destroy all copies of the transmission. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
