On Thu, May 18, 2017 at 01:44:58PM -0700, Jordan Justen wrote:
> On 2017-05-18 12:29:09, Laszlo Ersek wrote:
> > On 05/18/17 19:21, Jordan Justen wrote:
> > > On 2017-05-18 08:04:20, Laszlo Ersek wrote:
> > >> // All blocks must be within range
> > >> - DEBUG ((DEBUG_BLKIO, "FvbEraseBlocks: Check if: ( StartingLba=%ld +
> > >> NumOfLba=%d - 1 ) > LastBlock=%ld.\n", Instance->StartLba + StartingLba,
> > >> NumOfLba, Instance->Media.LastBlock));
> > >> + DEBUG ((
> > >> + DEBUG_BLKIO,
> > >> + "FvbEraseBlocks: Check if: ( StartingLba=%ld + NumOfLba=%Lu - 1 )
> > >> > LastBlock=%ld.\n",
> > >
> > > Notably this is still > 80 columns. Maybe?
> > >
> > > "FvbEraseBlocks: Check if: ( StartingLba=%ld + NumOfLba=%Lu - 1 ) "
> > > "> LastBlock=%ld.\n",
> >
> > This file ("ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c") has
> > extremely long lines, the longest one (line 774) has 172 columns. I
> > broke up the above DEBUG so that it would at least fit in 120 chars per
> > line (which is the "second level" recommendation in the coding spec).
>
> Personally, I don't agree with that secondary 120 char rule. If we
> ever get the style guide into an 'open source' process, I'd like to
> suggest removing it. (But, it'll probably get shot down. :\ )
Oh, I'm all for that one. And the style guide is definitely in need of
a shake-up.
But I consider violating line length restrictions less bad than making
user-(or in this case developer)-visible strings harder to search for.
> Ah. I guess it is fine for a package maintainer to occasionally decide
> to bend the rules for their package.
For this to be bending, it would require the 120-character rule to not
exist.
/
Leif
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
