Mike or Kelly, can one of you please review this patch? Thanks Laszlo
On 05/18/17 17:04, Laszlo Ersek wrote: > According to the PI spec, Volume 3, > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): > >> The variable argument list is a list of tuples. Each tuple describes a >> range of LBAs to erase and consists of the following: >> * An EFI_LBA that indicates the starting LBA >> * A UINTN that indicates the number of blocks to erase > > (NB, in edk2, EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL is a typedef to > EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.) > > In this driver, the NumOfLba local variable is defined with type UINTN, > but the TYPE argument passed to VA_ARG() is UINT32. Fix the mismatch. > > Cc: Jordan Justen <[email protected]> > Cc: Kelly Steele <[email protected]> > Cc: Michael D Kinney <[email protected]> > Reported-by: Jordan Justen <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <[email protected]> > --- > > Notes: > unbuilt, untested > > QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c > b/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c > index dbb5512f386e..0e7a7b79a1cf 100644 > --- a/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c > +++ b/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c > @@ -1211,7 +1211,7 @@ Returns: > break; > } > > - NumOfLba = VA_ARG (args, UINT32); > + NumOfLba = VA_ARG (args, UINTN); > > // > // Check input parameters > @@ -1235,7 +1235,7 @@ Returns: > break; > } > > - NumOfLba = VA_ARG (args, UINT32); > + NumOfLba = VA_ARG (args, UINTN); > > while (NumOfLba > 0) { > Status = FvbEraseBlock (FvbDevice->Instance, StartingLba, > mFvbModuleGlobal, EfiGoneVirtual ()); > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
