On 08/14/17 13:36, Brijesh Singh wrote: > Cc: Ard Biesheuvel <[email protected]> > Cc: Jordan Justen <[email protected]> > Cc: Tom Lendacky <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Brijesh Singh <[email protected]> > --- > OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 28 > ++++++++++---------- > OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 28 > ++++++++++---------- > 2 files changed, 28 insertions(+), 28 deletions(-) > > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > index 4130dbc043df..bedd635e1a86 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > @@ -85,29 +85,29 @@ VirtioMmioGetDeviceStatus ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueSize > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetDeviceStatus ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT8 DeviceStatus > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT8 DeviceStatus > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetQueueNotify ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueNotify > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueNotify > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSel ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Sel > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Sel > ); > > EFI_STATUS > @@ -119,22 +119,22 @@ VirtioMmioSetQueueAddress ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueAlignment ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 Alignment > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 Alignment > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetPageSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 PageSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 PageSize > ); > > EFI_STATUS > EFIAPI > VirtioMmioSetGuestFeatures ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT64 Features > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT64 Features > ); > > #endif // _VIRTIO_MMIO_DEVICE_INTERNAL_H_ > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > index 53c734f6b1af..9142d4a162c0 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > @@ -81,8 +81,8 @@ VirtioMmioGetDeviceStatus ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueSize > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -97,8 +97,8 @@ VirtioMmioSetQueueSize ( > EFI_STATUS > EFIAPI > VirtioMmioSetDeviceStatus ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT8 DeviceStatus > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT8 DeviceStatus > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -113,8 +113,8 @@ VirtioMmioSetDeviceStatus ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueNotify ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 QueueNotify > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 QueueNotify > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -129,8 +129,8 @@ VirtioMmioSetQueueNotify ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueAlignment ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 Alignment > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 Alignment > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -145,8 +145,8 @@ VirtioMmioSetQueueAlignment ( > EFI_STATUS > EFIAPI > VirtioMmioSetPageSize ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT32 PageSize > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT32 PageSize > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -165,8 +165,8 @@ VirtioMmioSetPageSize ( > EFI_STATUS > EFIAPI > VirtioMmioSetQueueSel ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT16 Sel > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT16 Sel > ) > { > VIRTIO_MMIO_DEVICE *Device; > @@ -197,8 +197,8 @@ VirtioMmioSetQueueAddress ( > EFI_STATUS > EFIAPI > VirtioMmioSetGuestFeatures ( > - VIRTIO_DEVICE_PROTOCOL *This, > - UINT64 Features > + IN VIRTIO_DEVICE_PROTOCOL *This, > + IN UINT64 Features > ) > { > VIRTIO_MMIO_DEVICE *Device; >
Reviewed-by: Laszlo Ersek <[email protected]> Regression-tested-by: Laszlo Ersek <[email protected]> Commit 22701a3d4dd1fd3eed385215d6e2dad0ad069b7f. Thanks Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel

