On 08/16/2017 10:32 AM, Laszlo Ersek wrote:
+
+EFI_STATUS
+EFIAPI
+VirtioPciUnmapSharedBuffer (
+ IN VIRTIO_DEVICE_PROTOCOL *This,
+ OUT VOID *Mapping
+ )
(1) Is this an Easter egg for your reviewer? :) "Mapping" should be IN,
not OUT.
This oversight is surprising -- or, well, an Easter egg :) -- because
the function declaration, in
"OvmfPkg/VirtioPciDeviceDxe/VirtioPciDevice.h" above, is correct.
Surprisingly, it didn't took you long time to find hidden Easter Egg,
I should work harder next time :)
Since now you have found it hence I will quietly go and fix patch 9 as well ;)
-Brijesh
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
