I found there's a logic hole in code. A new patch will be sent out. -----Original Message----- From: edk2-devel [mailto:[email protected]] On Behalf Of Jian J Wang Sent: Monday, September 18, 2017 11:09 AM To: [email protected] Cc: Kinney, Michael D <[email protected]>; Laszlo Ersek <[email protected]>; Yao, Jiewen <[email protected]>; Zeng, Star <[email protected]> Subject: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver
There're two issues here actually. >From GCD perspective, its SetMemorySpaceAttributes() method doesn't accept page related attributes. That means users cannot use it to change page attributes, and have to turn to CPU arch protocol to do it, which is not be allowed by PI spec. >From CpuDxe driver perspective, it doesn't update GCD memory attributes from current page table setup during its initialization. So the memory attributes in GCD might not reflect all memory attributes in real world. Cc: Jiewen Yao <[email protected]> Cc: Star Zeng <[email protected]> Cc: Laszlo Ersek <[email protected]> Cc: Michael Kinney <[email protected]> Suggested-by: Jiewen Yao <[email protected]> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang <[email protected]> Jian J Wang (2): MdeModulePkg/Core: Fix out-of-sync issue in GCD UefiCpuPkg/CpuDxe: Fix out-of-sync issue in page attributes MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 45 ++++++++++++-------- UefiCpuPkg/CpuDxe/CpuDxe.c | 5 +++ UefiCpuPkg/CpuDxe/CpuDxe.h | 9 ++++ UefiCpuPkg/CpuDxe/CpuPageTable.c | 92 ++++++++++++++++++++++++++++++++++++++++ 4 files changed, 133 insertions(+), 18 deletions(-) -- 2.14.1.windows.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
