Thanks. I have no other comments. From: Wang, Jian J Sent: Wednesday, September 20, 2017 3:54 PM To: Yao, Jiewen <[email protected]>; [email protected] Cc: Kinney, Michael D <[email protected]>; Laszlo Ersek <[email protected]>; Dong, Eric <[email protected]>; Zeng, Star <[email protected]> Subject: RE: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver
Jiewen, Yes. The patch has passed the validation of the UEFI booting Windows 10, Windows 7 and Fedora 25. If no comments from you and others, I'll push the patch to upstream soon. Thanks, Jian Wang -----Original Message----- From: Yao, Jiewen Sent: Wednesday, September 20, 2017 2:08 PM To: Wang, Jian J <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> Cc: Kinney, Michael D <[email protected]<mailto:[email protected]>>; Laszlo Ersek <[email protected]<mailto:[email protected]>>; Dong, Eric <[email protected]<mailto:[email protected]>>; Zeng, Star <[email protected]<mailto:[email protected]>> Subject: RE: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver Hi I take a look at the driver. I think the update is good. Would you please share what test you have done with the updated UEFI memory map? Such as UEFI Windows boot, UEFI Linux boot? Thank you Yao Jiewen > -----Original Message----- > From: Wang, Jian J > Sent: Wednesday, September 20, 2017 1:12 PM > To: Wang, Jian J <[email protected]<mailto:[email protected]>>; > [email protected]<mailto:[email protected]> > Cc: Kinney, Michael D > <[email protected]<mailto:[email protected]>>; Laszlo Ersek > <[email protected]<mailto:[email protected]>>; Yao, Jiewen > <[email protected]<mailto:[email protected]>>; Dong, Eric > <[email protected]<mailto:[email protected]>>; Zeng, Star > <[email protected]<mailto:[email protected]>> > Subject: RE: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU > driver > > Jiewen, > > Any comments on this patch? > > > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Jian J > Wang > Sent: Tuesday, September 19, 2017 2:10 PM > To: [email protected]<mailto:[email protected]> > Cc: Kinney, Michael D > <[email protected]<mailto:[email protected]>>; Laszlo Ersek > <[email protected]<mailto:[email protected]>>; Yao, Jiewen > <[email protected]<mailto:[email protected]>>; Dong, Eric > <[email protected]<mailto:[email protected]>>; Zeng, Star > <[email protected]<mailto:[email protected]>> > Subject: [edk2] [PATCH 0/2] Fixe out-of-sync issue between GCD and CPU driver > > There're two issues here actually. > > From GCD perspective, its SetMemorySpaceAttributes() method doesn't > accept page related attributes. That means users cannot use it to > change page attributes, and have to turn to CPU arch protocol to do it, > which is not be allowed by PI spec. > > From CpuDxe driver perspective, it doesn't update GCD memory attributes > from current page table setup during its initialization. So the memory > attributes in GCD might not reflect all memory attributes in real world. > > Cc: Jiewen Yao <[email protected]<mailto:[email protected]>> > Cc: Eric Dong <[email protected]<mailto:[email protected]>> > Cc: Star Zeng <[email protected]<mailto:[email protected]>> > Cc: Laszlo Ersek <[email protected]<mailto:[email protected]>> > Cc: Michael Kinney > <[email protected]<mailto:[email protected]>> > Suggested-by: Jiewen Yao <[email protected]<mailto:[email protected]>> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > <[email protected]<mailto:[email protected]>> > > Jian J Wang (2): > UefiCpuPkg/CpuDxe: Fix out-of-sync issue in CpuDxe > MdeModulePkg/Core: Fix out-of-sync issue in GCD > > MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 45 ++++++++++-------- > UefiCpuPkg/CpuDxe/CpuDxe.c | 5 ++ > UefiCpuPkg/CpuDxe/CpuDxe.h | 9 ++++ > UefiCpuPkg/CpuDxe/CpuPageTable.c | 99 > ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 140 insertions(+), 18 deletions(-) > > -- > 2.14.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected]<mailto:[email protected]> > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
