On 09/20/17 12:11, Ni, Ruiyu wrote:
> I am surprised that you don't know ECC tool. 😊
> It's a much more complex tool than PatchCheck.py.
> It's to report all coding style issues that doesn't follow EDKII C coding
> style.
Well, before my previous email, I tried to execute the command line you named,
but it didn't work:
$ source edksetup.sh
$ Ecc -t MdeModulePkg/Universal/Disk/PartitionDxe -s
Traceback (most recent call last):
File "BaseTools/BinWrappers/PosixLike/../../Source/Python/Ecc/Ecc.py", line
24, in <module>
from Check import Check
File "BaseTools/Source/Python/Ecc/Check.py", line 20, in <module>
import c
File "BaseTools/Source/Python/Ecc/c.py", line 18, in <module>
import CodeFragmentCollector
File "BaseTools/Source/Python/Ecc/CodeFragmentCollector.py", line 23, in
<module>
import antlr3
ImportError: No module named antlr3
Now I'v checked both Fedora and RHEL7 packages for an "antlr3" python module,
but it doesn't exist. The "antlr3" package itself exists in both distros, but
the changelogs say,
> * Thu Feb 23 2012 Miloš Jakubíček <xja...@fi.muni.cz>
> - 3.4-5 - Disable python runtime (incompatible with current antlr version)
The following RHBZ looks relevant:
<https://bugzilla.redhat.com/show_bug.cgi?id=1313024>
Either way, I don't think I can use the ECC tool.
Thanks,
Laszlo
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Wednesday, September 20, 2017 5:59 PM
>> To: Ni, Ruiyu <ruiyu...@intel.com>; Paulo Alcantara <pca...@zytor.com>;
>> edk2-devel@lists.01.org
>> Cc: Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com>
>> Subject: Re: [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of
>> UDF logical partition
>>
>> Ray,
>>
>> On 09/20/17 10:14, Ni, Ruiyu wrote:
>>
>>> When you add the header comments, please run Python
>>> BaseTools/Source/Python/Ecc/Ecc.py -t
>>> MdeModulePkg/Universal/Disk/PartitionDxe -s To make sure there is no
>> other coding style issue.
>>
>> side question: do you mean "PatchCheck.py"?
>>
>> I've never heard of "Ecc.py" before, what does it do? (The top comment only
>> says "This file is used to be the main entrance of ECC tool", and the
>> "BaseTools/UserManuals" directory doesn't seem to contain anything
>> related.)
>>
>> Thanks,
>> Laslzo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
