Laszlo: ECC depends on antlr V3.0.1. It can be downloaded from http://www.antlr3.org/download/Python/ After download it, use python setup.py install to install it. I try this way on Windows OS, it can work.
Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:[email protected]] On Behalf Of Laszlo > Ersek > Sent: Wednesday, September 20, 2017 7:10 PM > To: Ni, Ruiyu <[email protected]>; Paulo Alcantara <[email protected]>; > [email protected] > Cc: Dong, Eric <[email protected]>; Zeng, Star <[email protected]> > Subject: Re: [edk2] [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of > UDF logical partition > > On 09/20/17 12:11, Ni, Ruiyu wrote: > > I am surprised that you don't know ECC tool. 😊 > > It's a much more complex tool than PatchCheck.py. > > It's to report all coding style issues that doesn't follow EDKII C coding > > style. > > Well, before my previous email, I tried to execute the command line you > named, but it didn't work: > > $ source edksetup.sh > > $ Ecc -t MdeModulePkg/Universal/Disk/PartitionDxe -s > Traceback (most recent call last): > File "BaseTools/BinWrappers/PosixLike/../../Source/Python/Ecc/Ecc.py", line > 24, in <module> > from Check import Check > File "BaseTools/Source/Python/Ecc/Check.py", line 20, in <module> > import c > File "BaseTools/Source/Python/Ecc/c.py", line 18, in <module> > import CodeFragmentCollector > File "BaseTools/Source/Python/Ecc/CodeFragmentCollector.py", line 23, in > <module> > import antlr3 > ImportError: No module named antlr3 > > Now I'v checked both Fedora and RHEL7 packages for an "antlr3" python module, > but it doesn't exist. The "antlr3" package itself exists > in both distros, but the changelogs say, > > > * Thu Feb 23 2012 Miloš Jakubíček <[email protected]> > > - 3.4-5 - Disable python runtime (incompatible with current antlr version) > > The following RHBZ looks relevant: > <https://bugzilla.redhat.com/show_bug.cgi?id=1313024> > > Either way, I don't think I can use the ECC tool. > > Thanks, > Laszlo > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:[email protected]] > >> Sent: Wednesday, September 20, 2017 5:59 PM > >> To: Ni, Ruiyu <[email protected]>; Paulo Alcantara <[email protected]>; > >> [email protected] > >> Cc: Dong, Eric <[email protected]>; Zeng, Star <[email protected]> > >> Subject: Re: [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of > >> UDF logical partition > >> > >> Ray, > >> > >> On 09/20/17 10:14, Ni, Ruiyu wrote: > >> > >>> When you add the header comments, please run Python > >>> BaseTools/Source/Python/Ecc/Ecc.py -t > >>> MdeModulePkg/Universal/Disk/PartitionDxe -s To make sure there is no > >> other coding style issue. > >> > >> side question: do you mean "PatchCheck.py"? > >> > >> I've never heard of "Ecc.py" before, what does it do? (The top comment only > >> says "This file is used to be the main entrance of ECC tool", and the > >> "BaseTools/UserManuals" directory doesn't seem to contain anything > >> related.) > >> > >> Thanks, > >> Laslzo > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
