On 22 September 2017 at 15:12, Supreeth Venkatesh <[email protected]> wrote: > On Fri, 2017-09-22 at 22:45 +0100, Achin Gupta wrote: >> Hi Supreeth, >> >> On Fri, Sep 22, 2017 at 08:25:39PM +0100, Supreeth Venkatesh wrote: >> > >> > This patch adds a list of function IDs that fall under the standard >> > SMC range as defined in >> > http://infocenter.arm.com/help/topic/com.arm.doc.den0060a/DEN0060A_ >> > ARM_MM_Interface_Specification.pdf. >> > >> > SMCs associated with Management Mode are in the range 0xC4000040 - >> > 0xC400005f (64 bit) and 0x84000040 - 0x8400005f (32 bit). >> > >> > The function(s) available to the normal world: >> > 1. Request services from the secure MM environment using >> > MM_COMMUNICATE. >> > >> > SVCs are in the range 0xC4000060 - 0xC400007f. >> > The functions available to the secure MM partition: >> > 1. Signal completion of MM event handling. >> > 2. Set/Get memory attributes for a memory region at runtime. >> > 3. Get version number of secure partition manager. >> > >> > Also, it defines memory attributes and MM return codes. >> The SVCs in the 0xC4000060 - 0xC400007f range are not a part of the >> MM interface >> specification. At the moment, these are used to implement an >> interface between >> ARM TF in EL3 and S-EL0. These should go into a separate patch that >> introduces >> them as an ARM TF ABI. >> >> cheers, >> Achin > > Thanks for taking a look at it. This was added in ArmStdSmc.h > deliberately to request comments/feedback. I don't think SVC defines > belong in this file at all. It should have its own header file. > > Since it is specific to MM (S-EL0) - EL3 communication, I am tempted to > create a new header file named "ArmMmSvc.h" and put in > ArmPkg/Include/IndustryStandard folder. > > Comments - Maintainers/Anyone?
If these are only used for SVC calls from S-EL0, then yes, they should be in a separate header file. _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
