2017-10-06 17:57 GMT+02:00 Leif Lindholm <[email protected]>: > On Fri, Oct 06, 2017 at 09:51:16AM +0200, Marcin Wojtas wrote: >> This patch introduces UTMI description, using the new structures >> and template in MvHwDescLib. This change enables more flexible >> addition of multiple CP with UTMI PHY's and also significantly >> reduces amount of used PCD's for that purpose. Update PortingGuide >> documentation accordingly. >> >> This patch replaces string-based description of Utmi on >> Armada 70x0 DB with new, reduced format. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas <[email protected]> >> --- >> Platform/Marvell/Armada/Armada70x0.dsc | 7 +- >> Platform/Marvell/Include/Library/MvHwDescLib.h | 47 ++++++ >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 149 >> ++++++++++---------- >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 1 - >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 11 +- >> Platform/Marvell/Marvell.dec | 7 +- >> Silicon/Marvell/Documentation/PortingGuide.txt | 30 ++-- >> 7 files changed, 142 insertions(+), 110 deletions(-) >> >> diff --git a/Platform/Marvell/Armada/Armada70x0.dsc >> b/Platform/Marvell/Armada/Armada70x0.dsc >> index d9d126d..04bdf7c 100644 >> --- a/Platform/Marvell/Armada/Armada70x0.dsc >> +++ b/Platform/Marvell/Armada/Armada70x0.dsc >> @@ -111,11 +111,8 @@ >> gMarvellTokenSpaceGuid.PcdChip0ComPhySpeeds|{ 0x1, 0x6, 0xA, 0x6, 0x6, >> 0x6 } >> >> #UtmiPhy >> - gMarvellTokenSpaceGuid.PcdUtmiPhyCount|2 >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUsbCfg|L"0xF2440420;0xF2440420" >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiCfg|L"0xF2440440;0xF2440444" >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiUnit|L"0xF2580000;0xF2581000" >> - gMarvellTokenSpaceGuid.PcdUtmiPhyUtmiPort|L"0x0;0x1" >> + gMarvellTokenSpaceGuid.PcdUtmiControllers|{ 0x1, 0x1 } >> + gMarvellTokenSpaceGuid.PcdUtmiPortType|{ 0x0, 0x1 } > > Like for 1/5, could we have some entries under a [Define] in a .inc > (reasonably the same .inc)? >
Ok. Any preferences in terms of the name of such file? Unless we can just put it into Armada.dsc.inc... Best regards, Marcin _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
