On Tue, Oct 24, 2017 at 06:23:11PM +0200, Laszlo Ersek wrote: > On 10/24/17 17:28, Dong, Eric wrote: > > Laszlo, > > > > Thanks for your willing to review all CPU changes. We also found Ovmf is a > > very special system and need to take it in to consideration when do the > > changes. > > > > Reviewed-by: Eric Dong <[email protected]> > > Thank you Eric! > > Can one (or more) of the Stewards ACK as well please? > > (This is an admin change, not a code change, so I guess it should be > fine to push on Thursday or so.)
I am certainly happy with this, just wanted to hear from package maintainers first: Reviewed-by: Leif Lindholm <[email protected]> / Leif > Thanks! > Laszlo > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:[email protected]] > >> Sent: Tuesday, October 24, 2017 6:53 PM > >> To: edk2-devel-01 <[email protected]> > >> Cc: Andrew Fish <[email protected]>; Dong, Eric <[email protected]>; Jeff > >> Fan <[email protected]>; Leif Lindholm <[email protected]>; > >> Kinney, Michael D <[email protected]>; Ni, Ruiyu > >> <[email protected]> > >> Subject: [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg reviewer > >> > >> UefiCpuPkg hosts a number of modules (SMM infrastructure, > >> MP-initialization) that may behave differently enough between > >> virtualization > >> guests and physical boards that they merit regression testing and review > >> specifically from a virtualization perspective. > >> > >> Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on > >> all UefiCpuPkg patches. > >> > >>> R: Package Reviewer: Cc address for patches and questions. Reviewers > >>> help maintainers review code, but don't have push access. > >> > >> Cc: Andrew Fish <[email protected]> > >> Cc: Eric Dong <[email protected]> > >> Cc: Jeff Fan <[email protected]> > >> Cc: Leif Lindholm <[email protected]> > >> Cc: Michael D Kinney <[email protected]> > >> Cc: Ruiyu Ni <[email protected]> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> Signed-off-by: Laszlo Ersek <[email protected]> > >> --- > >> > >> Notes: > >> Recently there have been two UefiCpuPkg patches on the list that have > >> each spent hardly more than 24 hours in review: > >> > >> * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 > >> resume > >> finished.", 2017-10-11), > >> > >> * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP > >> initialization logic.", 2017-10-23). > >> > >> Both times, I was out of office, and didn't get a chance to comment. > >> The > >> first commit broke OVMF: > >> > >> http://mid.mail-archive.com/8d678707-fb07-0326-acfd- > >> [email protected] > >> https://github.com/tianocore/edk2/commit/152e8d7670d5 > >> > >> while the second commit has a good chance to break OVMF on at least > >> some > >> virt hosts: > >> > >> https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html > >> > >> I was not CC'd either time. Had I been CC'd, the automated > >> out-of-office > >> reply that I always set up would have been received on the submitter's > >> side, and I could have tested and/or commented on the patches in > >> question, before they were pushed. > >> > >> My intent as a UefiCpuPkg Reviewer is to be inserted in the patch > >> review > >> process for UefiCpuPkg. I should be explicitly CC'd; and my feedback > >> should please be waited upon. I think I've proved myself reasonably > >> responsive; I intend to follow up in a few days every time. My review > >> should definitely not replace Eric's review, but I'd like to get an > >> *official* chance to raise questions before a patch is pushed. Whenever > >> I have nothing to add, I'll send an Acked-by. Thanks. > >> > >> Maintainers.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Maintainers.txt b/Maintainers.txt index > >> c1a5723af9db..297a9bfd2b56 100644 > >> --- a/Maintainers.txt > >> +++ b/Maintainers.txt > >> @@ -245,6 +245,7 @@ M: Jaben Carsey <[email protected]> > >> UefiCpuPkg > >> W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg > >> M: Eric Dong <[email protected]> > >> +R: Laszlo Ersek <[email protected]> > >> > >> UnixPkg > >> W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg > >> -- > >> 2.14.1.3.gb7cf6e02401b > > > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
