Thanks for the feedback. > -----Original Message----- > From: Yao, Jiewen > Sent: Thursday, October 26, 2017 2:49 PM > To: Wang, Jian J <[email protected]>; [email protected] > Cc: Kinney, Michael D <[email protected]>; Wolman, Ayellet > <[email protected]>; Dong, Eric <[email protected]>; Zeng, Star > <[email protected]>; Yao, Jiewen <[email protected]> > Subject: RE: [edk2] [PATCH v3 0/6] Implement heap guard feature > > That is great work. Jian. > > Some suggestion for your consideration: > > 0) I suggest add Laszlo to review SMM part, and add Ruiyu to review > SMM_MEMORY_ATTRIBUTE_PROTOCOL. >
Ok, already pinged them. > 1) Would you please mention what test we have done for this feature? > Such as OVMF/realPlatform? IA32/X64? > I did following test: Boot to shell (OVMF/Intel platform) (both IA32 and X64) Boot to Fedora 25 (64 only) Windows 10 boot loader has a limit of 512-memory-descriptor, which will cause boot failure. This is due to a fact that enabling this feature will cause more memory fragments (pool memory). Since this is a debug feature, I suppose this is an acceptable result. > Have you validated NT32? Or try to enable protection? :-) > I did before first round of patch but not after. Let me check it again. Enabling protection in NT32 is a challenge because Windows API has some limitations which may need a huge changes to our memory management code. I'd suggest to leave NT32 alone or create a separate task for it. > 2) Is that any dependency of this patch? > I think there is OPENSSL wrapper reallocate() issue not resolved yet. > > I suggest we check in all dependent patch at first, then check in this one. > You're right. > 3) If you need submit V4, please separate > MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h from 2/6 to be a > standalone patch. In general, an interface and an implementation are > separated. > Sure. > > Thank you > Yao Jiewen > > > > > -----Original Message----- > > From: Wang, Jian J > > Sent: Wednesday, October 25, 2017 9:48 AM > > To: Wang, Jian J <[email protected]>; [email protected] > > Cc: Kinney, Michael D <[email protected]>; Wolman, Ayellet > > <[email protected]>; Yao, Jiewen <[email protected]>; Dong, > Eric > > <[email protected]>; Zeng, Star <[email protected]> > > Subject: RE: [edk2] [PATCH v3 0/6] Implement heap guard feature > > > > Hi, > > > > Just a warm reminding. I didn't see any feedbacks on the v3 patch. > > If no more comments, I'll check in the patch soon. > > > > Thanks, > > Jian > > > > > -----Original Message----- > > > From: edk2-devel [mailto:[email protected]] On Behalf Of > Jian J > > > Wang > > > Sent: Monday, October 23, 2017 8:51 AM > > > To: [email protected] > > > Cc: Kinney, Michael D <[email protected]>; Wolman, Ayellet > > > <[email protected]>; Yao, Jiewen <[email protected]>; Dong, > Eric > > > <[email protected]>; Zeng, Star <[email protected]> > > > Subject: [edk2] [PATCH v3 0/6] Implement heap guard feature > > > > > > > Patch V3 changes: > > > > a. Add new protocol gEdkiiSmmMemoryAttributeProtocolGuid to do > > > > memory attributes update instead of doing it directly in SmmCore > > > > b. Fix GCC build error > > > > > > > Patch V2 changes: > > > > a. Remove local variable initializer with memory copy from globals > > > > b. Change map table dump code to use DEBUG_PAGE|DEBUG_POOL level > > > > message > > > > c. Fix malfunction in 32-bit boot mode > > > > d. Add comment for the use of mOnGuarding > > > > e. Change name of function InitializePageTableLib to > > > > InitializePageTableGlobals > > > > f. Add code in 32-bit code to bypass setting page table to read-only > > > > g. Coding style clean-up > > > > > > > > > > This feature makes use of paging mechanism to add a hidden (not present) > > > page just before and after the allocated memory block. If the code tries > > > to access memory outside of the allocated part, page fault exception will > > > be triggered. > > > > > > This feature is disabled by default and is not recommended to enable it > > > in production build of BIOS. > > > > > > Cc: Star Zeng <[email protected]> > > > Cc: Eric Dong <[email protected]> > > > Cc: Jiewen Yao <[email protected]> > > > Cc: Michael Kinney <[email protected]> > > > Cc: Ayellet Wolman <[email protected]> > > > Suggested-by: Ayellet Wolman <[email protected]> > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Jian J Wang <[email protected]> > > > > > > Jian J Wang (6): > > > MdeModulePkg/DxeCore: Implement heap guard feature for UEFI > > > MdeModulePkg/PiSmmCore: Implement heap guard feature for SMM > > mode > > > MdeModulePkg/MdeModulePkg.dec,.uni: Add Protocol, PCDs and string > > > tokens > > > UefiCpuPkg/CpuDxe: Reduce debug message > > > UefiCpuPkg/PiSmmCpuDxeSmm: Disable page table protection > > > MdeModulePkg/DxeIpl: Enable paging for heap guard > > > > > > MdeModulePkg/Core/Dxe/DxeMain.inf | 4 + > > > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 1184 > > > ++++++++++++++++ > > > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 380 > > +++++ > > > MdeModulePkg/Core/Dxe/Mem/Imem.h | 38 +- > > > MdeModulePkg/Core/Dxe/Mem/Page.c | 130 +- > > > MdeModulePkg/Core/Dxe/Mem/Pool.c | 154 +- > > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 1 + > > > MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 29 +- > > > MdeModulePkg/Core/PiSmmCore/HeapGuard.c | 1469 > > > ++++++++++++++++++++ > > > MdeModulePkg/Core/PiSmmCore/HeapGuard.h | 399 > > ++++++ > > > MdeModulePkg/Core/PiSmmCore/Page.c | 51 +- > > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 7 +- > > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 81 +- > > > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 8 + > > > MdeModulePkg/Core/PiSmmCore/Pool.c | 81 +- > > > MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h | 136 ++ > > > MdeModulePkg/MdeModulePkg.dec | 60 + > > > MdeModulePkg/MdeModulePkg.uni | 58 + > > > UefiCpuPkg/CpuDxe/CpuPageTable.c | 5 +- > > > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 7 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 20 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 98 ++ > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 163 > > +++ > > > UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 3 +- > > > 25 files changed, 4472 insertions(+), 96 deletions(-) > > > create mode 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > > > create mode 100644 MdeModulePkg/Core/Dxe/Mem/HeapGuard.h > > > create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.c > > > create mode 100644 MdeModulePkg/Core/PiSmmCore/HeapGuard.h > > > create mode 100644 > > MdeModulePkg/Include/Protocol/SmmMemoryAttribute.h > > > > > > -- > > > 2.14.1.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > [email protected] > > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
