Hi Jian, On 10/26/17 09:38, Wang, Jian J wrote: > Thanks for the feedback. > >> -----Original Message----- >> From: Yao, Jiewen >> Sent: Thursday, October 26, 2017 2:49 PM >> To: Wang, Jian J <[email protected]>; [email protected] >> Cc: Kinney, Michael D <[email protected]>; Wolman, Ayellet >> <[email protected]>; Dong, Eric <[email protected]>; Zeng, Star >> <[email protected]>; Yao, Jiewen <[email protected]> >> Subject: RE: [edk2] [PATCH v3 0/6] Implement heap guard feature >> >> That is great work. Jian. >> >> Some suggestion for your consideration: >> >> 0) I suggest add Laszlo to review SMM part, and add Ruiyu to review >> SMM_MEMORY_ATTRIBUTE_PROTOCOL. >> > > Ok, already pinged them. > >> 1) Would you please mention what test we have done for this feature? >> Such as OVMF/realPlatform? IA32/X64? >> > > I did following test: > > Boot to shell (OVMF/Intel platform) (both IA32 and X64) > Boot to Fedora 25 (64 only)
May I ask if you used KVM virtualization (i.e., a Linux host computer) for this? https://github.com/tianocore/tianocore.github.io/wiki/Testing-SMM-with-QEMU,-KVM-and-libvirt > Windows 10 boot loader has a limit of 512-memory-descriptor, which will > cause boot failure. This is due to a fact that enabling this feature will > cause > more memory fragments (pool memory). Since this is a debug feature, I suppose > this is an acceptable result. This feature is large; I can't even attempt to review it in the time that I could allocate to it. However, I would like to regression test it (thank you Jiewen for the reference!) Preferably, given that a v4 is already planned, I should test v4. If you can post v4 on Oct 27th (tomorrow), I'll make an effort to test it in the afternoon / evening, on the 27th. (Please CC me.) Next week I will be mostly inactive on edk2-devel -- I wouldn't like to block your work, but I also wouldn't like an OVMF regression. Thanks, Laszlo _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
