Hi Jaben, No, we can't. InternalCharToUpper() is declared internally in BaseLib and unexported.
The comment above the declaration in UefiShellLevel2CommandsLib.c explains it: /** Be lazy and borrow from baselib. @param[in] Char The character to convert to upper case. @return Char as an upper case character. **/ Thanks, Paulo ________________________________________ From: Carsey, Jaben <[email protected]> Sent: Friday, October 27, 2017 4:33 PM To: Alcantara, Paulo; [email protected] Cc: Ni, Ruiyu Subject: RE: [PATCH] ShellPkg: Fix type mismatch with GCC Are we redefining a function from BaseLib? Why not remove the redundant definition instead of making it match? -Jaben > -----Original Message----- > From: Paulo Alcantara [mailto:[email protected]] > Sent: Friday, October 27, 2017 9:24 AM > To: [email protected] > Cc: Paulo Alcantara <[email protected]>; Carsey, Jaben > <[email protected]>; Ni, Ruiyu <[email protected]> > Subject: [PATCH] ShellPkg: Fix type mismatch with GCC > Importance: High > > This patch fixes the following warning reported by GCC 6.3: > > /home/pcacjr/src/edk2.git/ShellPkg/Library/UefiShellLevel2CommandsLib/U > efiShellLevel2CommandsLib.c:271:1: > warning: type of ‘InternalCharToUpper’ does not match original decl > aration [-Wlto-type-mismatch] > InternalCharToUpper ( > ^ > /home/pcacjr/src/edk2.git/MdePkg/Library/BaseLib/String.c:555:1: note: > ‘InternalCharToUpper’ was previously declared here > InternalCharToUpper ( > ^ > > Cc: Jaben Carsey <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Paulo Alcantara <[email protected]> > --- > > ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib > .c | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > index 7948e53cfc..bab6631e15 100644 > --- > a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > +++ > b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Commands > Lib.c > @@ -268,6 +268,7 @@ VerifyIntermediateDirectories ( > @return Char as an upper case character. > **/ > CHAR16 > +EFIAPI > InternalCharToUpper ( > IN CONST CHAR16 Char > ); > -- > 2.11.0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
