Please do not put this AHCI specific macro in Pci22.h.
I think only AtaAtapiPassThru driver needs to access the AHCI BAR,
There seems no need to expose this definition to public.

Thanks/Ray

> -----Original Message-----
> From: edk2-devel [mailto:[email protected]] On Behalf Of
> Meenakshi Aggarwal
> Sent: Monday, January 8, 2018 7:21 PM
> To: [email protected]; Gao, Liming <[email protected]>; Kinney,
> Michael D <[email protected]>; [email protected]
> Subject: [edk2] [PATCH] PCI : define macro for AHCI base address.
> 
> Define PCI BAR 5 macro of AHCI Base address.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <[email protected]>
> ---
>  MdePkg/Include/IndustryStandard/Pci22.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Pci22.h
> b/MdePkg/Include/IndustryStandard/Pci22.h
> index 96a7680..a63bb7c 100644
> --- a/MdePkg/Include/IndustryStandard/Pci22.h
> +++ b/MdePkg/Include/IndustryStandard/Pci22.h
> @@ -533,6 +533,7 @@ typedef struct {
>  #define PCI_HEADER_TYPE_OFFSET                      0x0E
>  #define PCI_BIST_OFFSET                             0x0F
>  #define PCI_BASE_ADDRESSREG_OFFSET                  0x10
> +#define PCI_AHCI_BASE_ADDRESS                       0x24
>  #define PCI_CARDBUS_CIS_OFFSET                      0x28
>  #define PCI_SVID_OFFSET                             0x2C ///< SubSystem 
> Vendor id
>  #define PCI_SUBSYSTEM_VENDOR_ID_OFFSET              0x2C
> --
> 1.9.1
> 
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to