Thanks Ray for your comment. Yes, only AtaAtapiPassThru Driver will need this.
Will take care of it. Thanks, Meenakshi > -----Original Message----- > From: Ni, Ruiyu [mailto:[email protected]] > Sent: Monday, January 08, 2018 11:32 AM > To: Meenakshi Aggarwal <[email protected]>; > [email protected]; Gao, Liming <[email protected]>; Kinney, > Michael D <[email protected]>; [email protected] > Subject: RE: [edk2] [PATCH] PCI : define macro for AHCI base address. > > Please do not put this AHCI specific macro in Pci22.h. > I think only AtaAtapiPassThru driver needs to access the AHCI BAR, > There seems no need to expose this definition to public. > > Thanks/Ray > > > -----Original Message----- > > From: edk2-devel [mailto:[email protected]] On Behalf Of > > Meenakshi Aggarwal > > Sent: Monday, January 8, 2018 7:21 PM > > To: [email protected]; Gao, Liming <[email protected]>; > Kinney, > > Michael D <[email protected]>; [email protected] > > Subject: [edk2] [PATCH] PCI : define macro for AHCI base address. > > > > Define PCI BAR 5 macro of AHCI Base address. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Meenakshi Aggarwal <[email protected]> > > --- > > MdePkg/Include/IndustryStandard/Pci22.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MdePkg/Include/IndustryStandard/Pci22.h > > b/MdePkg/Include/IndustryStandard/Pci22.h > > index 96a7680..a63bb7c 100644 > > --- a/MdePkg/Include/IndustryStandard/Pci22.h > > +++ b/MdePkg/Include/IndustryStandard/Pci22.h > > @@ -533,6 +533,7 @@ typedef struct { > > #define PCI_HEADER_TYPE_OFFSET 0x0E > > #define PCI_BIST_OFFSET 0x0F > > #define PCI_BASE_ADDRESSREG_OFFSET 0x10 > > +#define PCI_AHCI_BASE_ADDRESS 0x24 > > #define PCI_CARDBUS_CIS_OFFSET 0x28 > > #define PCI_SVID_OFFSET 0x2C ///< SubSystem > > Vendor id > > #define PCI_SUBSYSTEM_VENDOR_ID_OFFSET 0x2C > > -- > > 1.9.1 > > > > _______________________________________________ > > edk2-devel mailing list > > [email protected] > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist > s.01.org%2Fmailman%2Flistinfo%2Fedk2- > devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C33c2199113d > 5420bad2808d5565d4ba6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > %7C636509881114358526&sdata=5GgVYhmdN%2BlORXpC7yM6Xmq5LMOAV > K2rPsGWgDdmUPA%3D&reserved=0 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
